webnn: Set a max operand rank of 8 #47711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We likely eventually want this to be part of MLOpSupportsLimits, but for now this allows us to replace some checked-casts in favor of static-casts, and not need to worry about tensors with absurd ranks See webmachinelearning/webnn#456 Bug: 329482489 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14-blink-rel,mac14.arm64-blink-rel Change-Id: I021d3b30ea1b8f5f3bef1725130fd2e4c569f494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5639505 Reviewed-by: ningxin hu <ningxin.hu@intel.com> Reviewed-by: Phillis Tang <phillis@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/main@{#1344800}
wpt-pr-bot
approved these changes
Aug 21, 2024
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5639505
branch
from
3fa46f8 to
9918dff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We likely eventually want this to be part of MLOpSupportsLimits, but
for now this allows us to replace some checked-casts in favor of
static-casts, and not need to worry about tensors with absurd ranks
See webmachinelearning/webnn#456
Bug: 329482489
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14-blink-rel,mac14.arm64-blink-rel
Change-Id: I021d3b30ea1b8f5f3bef1725130fd2e4c569f494
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5639505
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Reviewed-by: Phillis Tang <phillis@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Austin Sullivan <asully@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1344800}