[wptrunner] Support testdriver.js in {ref,print-ref,crash}tests #48486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This no-op refactor will allow other WebDriver executors, not just the testharness executor, to perform testdriver actions.
This will allow non-testharness tests to use `testdriver.js` without needing extra scripts. Evaluating `message-queue.js` is idempotent so that, when using testharness with testdriver, the second inclusion is a no-op. Because resource scripts are cached, the size increase should not meaningfully affect test performance.
jonathan-j-lee
force-pushed
the
wptrunner/testdriver-reftest
branch
2 times, most recently
from
f3e9cfb
to
7568d4c
Compare
This will let wptrunner gracefully skip testdriver tests if the executor doesn't support them.
jonathan-j-lee
force-pushed
the
wptrunner/testdriver-reftest
branch
3 times, most recently
from
41b2fb1
to
c4a6d69
Compare
jonathan-j-lee
force-pushed
the
wptrunner/testdriver-reftest
branch
2 times, most recently
from
3796049
to
7b80717
Compare
Non-testharness executors that don't support testdriver simply skip those tests.
jonathan-j-lee
force-pushed
the
wptrunner/testdriver-reftest
branch
from
7b80717
to
25d7265
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP implementation for #13183 (will also need RFC)