Make <selectedoption> stop responding to mutations #48913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch makes <selectedoption> stop using the MutationObserver for <option>: openui/open-ui#825 This patch also uncovered a small bug with the selectedoptionelement attribute when assigning null to the IDL attribute, which I fixed by removing a null check. Bug: 336844298 Change-Id: I3fed171bf687cabb9474d8ff8741071c28bbad0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5941575 Reviewed-by: Dominic Farolino <dom@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1376573}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5941575
branch
from
de41f68 to
25a7e57
Compare
wpt-pr-bot
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes <selectedoption> stop using the MutationObserver for
<option>: openui/open-ui#825
This patch also uncovered a small bug with the
selectedoptionelement attribute when assigning null to the IDL
attribute, which I fixed by removing a null check.
Bug: 336844298
Change-Id: I3fed171bf687cabb9474d8ff8741071c28bbad0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5941575
Reviewed-by: Dominic Farolino <dom@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1376573}