-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[testdriver] Add test_driver.bidi.bluetooth.simulate_adapter
#49193
Open
sadym-chromium
wants to merge
3
commits into
master
Choose a base branch
from
sadym/testdriver-bluetooth
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
added
infra
testdriver.js
wptrunner
The automated test runner, commonly called through ./wpt run
labels
Nov 15, 2024
sadym-chromium
requested review from
OrKoN
and removed request for
jgraham,
foolip and
DanielRyanSmith
November 15, 2024 12:47
OrKoN
approved these changes
Nov 15, 2024
sadym-chromium
force-pushed
the
sadym/testdriver-bluetooth
branch
from
November 15, 2024 12:55
2e18a9c
to
dd30e01
Compare
There are no reviewers for this pull request. Please reach out on the chat room to get help with this. Thank you! |
past
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one nit.
infrastructure/testdriver/bidi/bluetooth/simulate_adapter.https.html
Outdated
Show resolved
Hide resolved
OrKoN
reviewed
Nov 15, 2024
infrastructure/testdriver/bidi/bluetooth/simulate_adapter.https.html
Outdated
Show resolved
Hide resolved
OrKoN
force-pushed
the
sadym/testdriver-bluetooth
branch
from
November 15, 2024 18:55
9f5d3b4
to
c2a29d4
Compare
Add `test_driver.bidi.bluetooth.simulate_adapter` method matching [`bluetooth.simulateAdapter`](https://webbluetoothcg.github.io/web-bluetooth/#bluetooth-simulateAdapter-command)WebDriver BiDi command. RFC is not required, as the method matches a WebDriver BiDi command.
sadym-chromium
force-pushed
the
sadym/testdriver-bluetooth
branch
from
November 15, 2024 20:41
c2a29d4
to
567efd1
Compare
I added a section to "testdriver.js Automation" doc section |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
docs
infra
status:needs-reviewers
testdriver.js
wptrunner
The automated test runner, commonly called through ./wpt run
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
test_driver.bidi.bluetooth.simulate_adapter
method matchingbluetooth.simulateAdapter
WebDriver BiDi command.RFC is not required, as the method matches a WebDriver BiDi command.