Reland "webnn: implement reverse operator" #49207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a reland of commit 0459ac1a9b94c1dd3e11410f7fb74f0a8e2ddeaf The previous CL got reverted because another CL[1] changed the function name `buildGraphAndCompute` to `buildAndExecuteGraph` in WPT. This CL fixes the name. [1] https://chromium-review.googlesource.com/c/chromium/src/+/5556220 Original change's description: > webnn: implement reverse operator > > This CL adds IDL and mojo definition of reverse operator according to > the spec issue [1] and implements it on DirectML backend. > > [1] webmachinelearning/webnn#773 > > Bug: 376707210 > Change-Id: I0d42b49b87ce243db9d44512e6000c7ee901077b > Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5979825 > Commit-Queue: ningxin hu <ningxin.hu@intel.com> > Auto-Submit: Shiyi Zou <shiyi.zou@intel.com> > Reviewed-by: Austin Sullivan <asully@chromium.org> > Reviewed-by: ningxin hu <ningxin.hu@intel.com> > Cr-Commit-Position: refs/heads/main@{#1382078} Bug: 376707210 Change-Id: I604de69bcc5f8932ac47f9f34a9b4c58e589193d Cq-Include-Trybots: luci.chromium.try:mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6015938 Reviewed-by: ningxin hu <ningxin.hu@intel.com> Commit-Queue: Shiyi Zou <shiyi.zou@intel.com> Auto-Submit: Shiyi Zou <shiyi.zou@intel.com> Reviewed-by: Weizhong Xia <weizhong@google.com> Reviewed-by: Alex Gough <ajgo@chromium.org> Reviewed-by: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/main@{#1384152}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6015938
branch
from
5fe69bd to
338b243
Compare
wpt-pr-bot
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reland of commit 0459ac1a9b94c1dd3e11410f7fb74f0a8e2ddeaf
The previous CL got reverted because another CL[1] changed the function
name
buildGraphAndComputetobuildAndExecuteGraphin WPT. This CLfixes the name.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/5556220
Original change's description:
Bug: 376707210
Change-Id: I604de69bcc5f8932ac47f9f34a9b4c58e589193d
Cq-Include-Trybots: luci.chromium.try:mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6015938
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Commit-Queue: Shiyi Zou <shiyi.zou@intel.com>
Auto-Submit: Shiyi Zou <shiyi.zou@intel.com>
Reviewed-by: Weizhong Xia <weizhong@google.com>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Austin Sullivan <asully@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1384152}