[Interop] WPT and fix for click dispatch with chorded buttons. #49656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CL adds a WPT for click-like events from chorded buttons, which is currently being discussed in PEWG as an Interop problem: w3c/pointerevents#530 The CL also fixes a behind-a-flag crack in Chromium. The crack prevented firing of click-like events with the chorded buttons when ClickToCapturedPointer is enabled. This is because the call to `DispatchMouseClickIfNeeded` is wrongly skipped in this case since the `pointer_event->type()` is `kPointermove` not `kPointerup`. Bug: 40851596 Change-Id: I11606ed8f709f08aaa2d8aba3ebaeb07f26bbc1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6059955 Reviewed-by: Robert Flack <flackr@chromium.org> Auto-Submit: Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1395404}
wpt-pr-bot
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds a WPT for click-like events from chorded buttons, which
is currently being discussed in PEWG as an Interop problem:
w3c/pointerevents#530
The CL also fixes a behind-a-flag crack in Chromium. The crack
prevented firing of click-like events with the chorded buttons when
ClickToCapturedPointer is enabled. This is because the call to
DispatchMouseClickIfNeededis wrongly skipped in this case sincethe
pointer_event->type()iskPointermovenotkPointerup.Bug: 40851596
Change-Id: I11606ed8f709f08aaa2d8aba3ebaeb07f26bbc1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6059955
Reviewed-by: Robert Flack <flackr@chromium.org>
Auto-Submit: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1395404}