Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing new-line at the end of lint.ignore #49823

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

jiangzhaoming
Copy link
Contributor

This PR add a missing new line at the end of lint.ignore, to fix the broken CTS CI workflow which would write line to that file assuming there is a new line existed at the end of file.

This PR add a missing new line at the end of `lint.ignore`, to fix the broken CTS CI workflow which would write line to that file assuming there is a new line existed at the end of file.
@jiangzhaoming
Copy link
Contributor Author

@past @Ms2ger @titzer @jgraham Please take a look, thanks!
This issue is imported via PR #49809, which modifies the lint.ignore but miss the new line at the end of file.

@jiangzhaoming
Copy link
Contributor Author

@greggman @Jiawei-Shao @shaoboyan091 I think this is the cause of WebGPU CTS CI workflow failure, and I test this fix could fix it.

The workflow (example) has a step of echo "TRAILING WHITESPACE, INDENT TABS, CR AT EOL: *.bin" >> wpt/lint.ignore right before running ./wpt lint, namely adding wpt lint ignore rule for *.bin, and the missing new line make the modified file ends with

PROMISE_REJECTS: wasm/core/js/harness/testharness.jsTRAILING WHITESPACE, INDENT TABS, CR AT EOL: *.bin

instead of

PROMISE_REJECTS: wasm/core/js/harness/testharness.js
TRAILING WHITESPACE, INDENT TABS, CR AT EOL: *.bin

and fails the parser.

@past past merged commit 369ee94 into web-platform-tests:master Dec 23, 2024
10 checks passed
@jiangzhaoming
Copy link
Contributor Author

Thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants