Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wdspec] check that subscription IDs are returned #50019

Merged
merged 1 commit into from
Jan 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions webdriver/tests/bidi/session/subscribe/subscription_id.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import pytest
import uuid

@pytest.mark.asyncio
async def test_subscribe_subscription_id(subscribe_events):
result = await subscribe_events(events=["browsingContext"])
assert isinstance(result['subscription'], str)
uuid.UUID(hex=result['subscription'])
3 changes: 2 additions & 1 deletion webdriver/tests/support/fixtures_bidi.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,9 @@ async def subscribe_events(bidi_session):
subscriptions = []

async def subscribe_events(events, contexts=None):
await bidi_session.session.subscribe(events=events, contexts=contexts)
result = await bidi_session.session.subscribe(events=events, contexts=contexts)
subscriptions.append((events, contexts))
return result

yield subscribe_events

Expand Down