Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceWorker: Change base URL for parsing script URL and scope URL #5016

Merged
merged 1 commit into from
Feb 25, 2017

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

According to the spec change, this changes to use the relevant settings object
instead of the entry settings object to parse the script URL and the scope URL
given to ServiceWorkerContainer.register() and
ServiceWorkerContainer.getRegistration().

Before this CL, register() and getRegistration() used entered execution context
to parse the URLs. After this CL, the methods use the execution context
retrieved from ScriptState::getExecutionContext().

WPT: external/wpt/service-workers/service-worker/multi-globals/url-parsing.https.html

Spec issue: w3c/ServiceWorker#922
Spec change: w3c/ServiceWorker@ec1aac2

BUG=691008

Review-Url: https://codereview.chromium.org/2691903005
Cr-Commit-Position: refs/heads/master@{#453033}

According to the spec change, this changes to use the relevant settings object
instead of the entry settings object to parse the script URL and the scope URL
given to ServiceWorkerContainer.register() and
ServiceWorkerContainer.getRegistration().

Before this CL, register() and getRegistration() used entered execution context
to parse the URLs. After this CL, the methods use the execution context
retrieved from ScriptState::getExecutionContext().

WPT: external/wpt/service-workers/service-worker/multi-globals/url-parsing.https.html

Spec issue: w3c/ServiceWorker#922
Spec change: w3c/ServiceWorker@ec1aac2

BUG=691008

Review-Url: https://codereview.chromium.org/2691903005
Cr-Commit-Position: refs/heads/master@{#453033}
@wpt-pr-bot
Copy link
Collaborator

Notifying @ehsan and @mkruisselbrink. (Learn how reviewing works.)

@ghost
Copy link

ghost commented Feb 25, 2017

View the complete job log.

Firefox (nightly channel)

Testing web-platform-tests at revision 033224ad656db2304f20c376dc7b96c601276c73
Using browser at version BuildID 20170224110129; SourceStamp be661bae6cb9a53935c5b87744bf68879d9ebcc5
Starting 10 test iterations
All results were stable

All results

3 tests ran
/service-workers/service-worker/multiple-register.https.html
Subtest Results
OK
Subsequent registrations resolve to the same registration object PASS
Concurrent registrations resolve to the same registration object PASS
Subsequent registrations from a different iframe resolve to the different registration object but they refer to the same registration and workers FAIL
/service-workers/service-worker/controller-on-reload.https.html
Subtest Results
OK
controller is set upon reload after registration FAIL
/service-workers/service-worker/registration-iframe.https.html
Subtest Results
OK
register method should use the "relevant global object" to parse its scriptURL and scope - normal case FAIL
A scope url should start with the given script url FAIL
register method should use the "relevant global object" to parse its scriptURL and scope - error case FAIL

@ghost
Copy link

ghost commented Feb 25, 2017

View the complete job log.

Chrome (unstable channel)

Testing web-platform-tests at revision 033224ad656db2304f20c376dc7b96c601276c73
Using browser at version 58.0.3018.3 dev
Starting 10 test iterations
All results were stable

All results

3 tests ran
/service-workers/service-worker/multiple-register.https.html
Subtest Results
OK
Subsequent registrations resolve to the same registration object PASS
Concurrent registrations resolve to the same registration object PASS
Subsequent registrations from a different iframe resolve to the different registration object but they refer to the same registration and workers FAIL
/service-workers/service-worker/controller-on-reload.https.html
Subtest Results
OK
controller is set upon reload after registration FAIL
/service-workers/service-worker/registration-iframe.https.html
Subtest Results
OK
register method should use the "relevant global object" to parse its scriptURL and scope - normal case FAIL
A scope url should start with the given script url FAIL
register method should use the "relevant global object" to parse its scriptURL and scope - error case FAIL

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 0be3f21 into master Feb 25, 2017
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-try branch February 25, 2017 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants