-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch: use .any.js syntax #5129
Conversation
Notifying @jdm and @youennf. (Learn how reviewing works.) |
If folks are generally supportive of this idea I'll start adding all the other resources to this PR. |
Firefox (nightly channel)Testing web-platform-tests at revision 0e57da0 All results1 test ran/fetch/api/basic/request-referrer-redirected-worker.html
|
Chrome (unstable channel)Testing web-platform-tests at revision 0e57da0 All results1 test ran/fetch/api/basic/request-referrer-redirected-worker.html
|
I am very much in favour of this. |
importScripts("/resources/testharness.js"); | ||
importScripts("../resources/utils.js"); | ||
} | ||
// META: script=../resources/utils.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woah, this works? That's neat...
I would prefer to get this landed and then cleanup more once #4102 is all done. @jdm could you review? (I did personally look through all results for .html and .worker.html auto-generated resources. I should probably do that again once it's all cleaned up as there are some browser bugs that need to be sorted somehow.) |
Sorry about the delay; this caught me while I was on vacation. |
Ah, thanks @jdm. I'll rebase first for the conflicting files. |
c24a11e
to
b21376b
Compare
I only modified fetch/api/cors/cors-preflight.any.js fetch/api/cors/cors-preflight-star.any.js while rebasing and it appears I successfully merged the changes made to those resources on master. So this can land once the checks are complete unless anyone has remaining concerns. I'll be happy to land these myself and give them a clean commit message. |
No description provided.