Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch: use .any.js syntax #5129

Merged
merged 5 commits into from
Mar 27, 2017
Merged

Fetch: use .any.js syntax #5129

merged 5 commits into from
Mar 27, 2017

Conversation

annevk
Copy link
Member

@annevk annevk commented Mar 13, 2017

No description provided.

@wpt-pr-bot
Copy link
Collaborator

Notifying @jdm and @youennf. (Learn how reviewing works.)

@annevk
Copy link
Member Author

annevk commented Mar 13, 2017

If folks are generally supportive of this idea I'll start adding all the other resources to this PR.

@ghost
Copy link

ghost commented Mar 13, 2017

View the complete job log.

Firefox (nightly channel)

Testing web-platform-tests at revision 0e57da0
Using browser at version BuildID 20170326110231; SourceStamp f5e214144799889e2408c4841351f4053f00544e
Starting 10 test iterations
All results were stable

All results

1 test ran
/fetch/api/basic/request-referrer-redirected-worker.html
Subtest Results Messages
OK
about:client referrer PASS {}
url referrer PASS {}

@ghost
Copy link

ghost commented Mar 13, 2017

View the complete job log.

Chrome (unstable channel)

Testing web-platform-tests at revision 0e57da0
Using browser at version 59.0.3047.0 dev
Starting 10 test iterations
All results were stable

All results

1 test ran
/fetch/api/basic/request-referrer-redirected-worker.html
Subtest Results Messages
OK
about:client referrer PASS {}
url referrer PASS {}

@jdm
Copy link
Contributor

jdm commented Mar 13, 2017

I am very much in favour of this.

importScripts("/resources/testharness.js");
importScripts("../resources/utils.js");
}
// META: script=../resources/utils.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah, this works? That's neat...

@annevk
Copy link
Member Author

annevk commented Mar 14, 2017

I would prefer to get this landed and then cleanup more once #4102 is all done. @jdm could you review? (I did personally look through all results for .html and .worker.html auto-generated resources. I should probably do that again once it's all cleaned up as there are some browser bugs that need to be sorted somehow.)

@jdm
Copy link
Contributor

jdm commented Mar 27, 2017

Sorry about the delay; this caught me while I was on vacation.

@annevk
Copy link
Member Author

annevk commented Mar 27, 2017

Ah, thanks @jdm. I'll rebase first for the conflicting files.

@annevk annevk force-pushed the annevk/reduce-boilerplate branch from c24a11e to b21376b Compare March 27, 2017 15:44
@annevk
Copy link
Member Author

annevk commented Mar 27, 2017

I only modified fetch/api/cors/cors-preflight.any.js fetch/api/cors/cors-preflight-star.any.js while rebasing and it appears I successfully merged the changes made to those resources on master. So this can land once the checks are complete unless anyone has remaining concerns.

I'll be happy to land these myself and give them a clean commit message.

@annevk annevk merged commit f6100de into master Mar 27, 2017
@annevk annevk deleted the annevk/reduce-boilerplate branch March 27, 2017 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants