Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set font when testing font relative units to make sure test is portable. #5252

Merged
merged 2 commits into from
Oct 5, 2017
Merged

Set font when testing font relative units to make sure test is portable. #5252

merged 2 commits into from
Oct 5, 2017

Conversation

gsnedders
Copy link
Member

@gsnedders gsnedders commented Mar 29, 2017 •
edited by wpt-pr-bot
Loading

From w3c/csswg-test#687

Originally posted as w3c/csswg-test#687 by @bemjb on 02 Dec 2014, 20:52 UTC:

... is portable.

@wpt-pr-bot
Copy link
Collaborator

Notifying @astearns, @atanassov, @bemjb, @kojiishi, @plinss, and @zhorvath. (Learn how reviewing works.)

@ghost
Copy link

ghost commented Mar 29, 2017 •
edited by ghost
Loading

View the complete job log.

Firefox (nightly channel)

Testing web-platform-tests at revision ea03338
Using browser at version BuildID 20170405115424; SourceStamp b043233ec04f06768d59dcdfb9e928142280f3cc
Starting 10 test iterations

@ghost
Copy link

ghost commented Mar 29, 2017 •
edited by ghost
Loading

View the complete job log.

Chrome (unstable channel)

Testing web-platform-tests at revision ea03338
Using browser at version 59.0.3053.3 dev
Starting 10 test iterations

@gsnedders
Copy link
Member Author

Gratuitous test comment: w3c/csswg-test#687 (comment).

@wpt-issue-mover wpt-issue-mover mentioned this pull request Mar 31, 2017
Closed
@wpt-issue-mover
Copy link

Originally posted as w3c/csswg-test#687 (comment) by @syncbot on 02 Dec 2014, 20:52 UTC:

Automatic validation checks of commit 03908d7 passed.

@wpt-issue-mover
Copy link

Originally posted as w3c/csswg-test#687 (comment) by @syncbot on 02 Dec 2014, 21:23 UTC:

Automatic validation checks of commit e2ccadd passed.

@wpt-issue-mover
Copy link

Originally posted as w3c/csswg-test#687 (comment) by @rhauck on 03 Dec 2014, 00:32 UTC:

LGTM. Imported and ran in Blink, but we're still waiting on another bug fix to make them pass. Merging.

@wpt-issue-mover
Copy link

Originally posted as w3c/csswg-test#687 (comment) by @gsnedders on 16 Aug 2016, 23:52 UTC:

I find no evidence of this having been merged despite @rhauck's prior comment.

@wpt-issue-mover
Copy link

Originally posted as w3c/csswg-test#687 (comment) by @svgeesus on 28 Mar 2017, 22:55 UTC:

"merge pull request" is greyed out, because there is a travis integration test that seems to have timed out (like, last year). How to bump this forward?

@wpt-issue-mover
Copy link

Originally posted as w3c/csswg-test#687 (comment) by @gsnedders on 28 Mar 2017, 23:18 UTC:

@svgeesus well, given we've merged into web-platform-tests, this needs to be rebased/merged for that, and a PR opened there, which per what I've said before and the README on the homepage of the repo here, I'll do later this week

gsnedders
gsnedders commented Apr 6, 2017
View reviewed changes
css/css-shapes-1/shape-outside/values/shape-outside-computed-shape-000.html Outdated
resolveds[unit] = parseFloat(s.width);
});
document.body.removeChild(div);
var resolveds = {};
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gratuitous whitespace

@ghost
Copy link

ghost commented Apr 6, 2017

These tests are now available on w3c-test.org

@gsnedders
Copy link
Member Author

Travis has hit #5408 on https://travis-ci.org/w3c/web-platform-tests/builds/219366884 (PR build) but not https://travis-ci.org/w3c/web-platform-tests/builds/219366867 (branch build).

@ghost
Copy link

ghost commented Oct 5, 2017 •
edited by ghost
Loading

Build PASSED

Started: 2017-10-05 15:16:23
Finished: 2017-10-05 15:41:08

Failing Jobs

  • safari:10.0
  • MicrosoftEdge:14.14393

View more information about this build on:

astearns
astearns approved these changes Oct 5, 2017
View reviewed changes
Copy link
Contributor

@astearns astearns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's get these changes in finally.

@gsnedders gsnedders merged commit c07c5ed into master Oct 5, 2017
@gsnedders gsnedders deleted the csswg-test-pr-687 branch October 5, 2017 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astearns astearns astearns approved these changes

@atanassov atanassov Awaiting requested review from atanassov

@bemjb bemjb Awaiting requested review from bemjb

@kojiishi kojiishi Awaiting requested review from kojiishi

@plinss plinss Awaiting requested review from plinss

@zhorvath zhorvath Awaiting requested review from zhorvath

Assignees
No one assigned
Labels
css-shapes reviewed wg-css
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gsnedders @wpt-pr-bot @wpt-issue-mover @astearns @bemjb