-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stability script: normalize results format #5330
Merged
gsnedders
merged 1 commit into
web-platform-tests:master
from
bocoup:stability-unstable-test-bug
Apr 4, 2017
Merged
Stability script: normalize results format #5330
gsnedders
merged 1 commit into
web-platform-tests:master
from
bocoup:stability-unstable-test-bug
Apr 4, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "check stability" script parses test results into a List of tuples. Later operations expect the fourth element to be a (possibly empty) List of "messages". While this expectation is satisfied when the instability is the result of a subtest's behavior, the parsing operation previously violated the contract when interpreting test failures. Update the parsing logic to provide an empty List in cases where a test (rather than a subtest) is the source of instability.
Firefox (nightly channel)Testing web-platform-tests at revision 161fed7 All results2 tests ran/service-workers/service-worker/fetch-event.https.html
/service-workers/service-worker/navigation-preload/redirect.https.html
|
Chrome (unstable channel)Testing web-platform-tests at revision 161fed7 All results2 tests ran/service-workers/service-worker/fetch-event.https.html
/service-workers/service-worker/navigation-preload/redirect.https.html
|
This was referenced Apr 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "check stability" script parses test results into a List of tuples.
Later operations expect the fourth element to be a (possibly empty) List
of "messages". While this expectation is satisfied when the instability
is the result of a subtest's behavior, the parsing operation previously
violated the contract when interpreting test failures.
Update the parsing logic to provide an empty List in cases where a test
(rather than a subtest) is the source of instability.