Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-grid] Add test to verify the minimum size of images #5337

Merged
merged 2 commits into from
May 25, 2017
Merged

[css-grid] Add test to verify the minimum size of images #5337

merged 2 commits into from
May 25, 2017

Conversation

mrego
Copy link
Member

@mrego mrego commented Apr 4, 2017 •
edited by wpt-pr-bot
Loading

This is a test created from issue w3c/csswg-drafts#1117.
The test checks how the automatic minimum size of images affect
to the grid container sizing and the track sizes.
The test also verifies the size of the image in the different cases.

The test combines the following cases:

  • A grid container with fixed width (smaller and bigger than the image).
  • A constrained grid container.
  • A grid container without default "justify-content: stretch".
  • A grid container with an extra test item.
  • An image with a fixed width (smaller and bigger than the image original size).
  • An image with a percentage width.

@svillar after the discussion in w3c/csswg-drafts#1117 it seems that per current spec this test is right.
Maybe we can land it as is and update it when the spec changes, or do you think it's better to wait until the spec is modified?

@wpt-pr-bot
Copy link
Collaborator

Notifying @atanassov, @fantasai, @jxs, @plinss, @tabatkins, and @tomalec. (Learn how reviewing works.)

@mrego mrego mentioned this pull request Apr 4, 2017
Closed
@ghost
Copy link

ghost commented Apr 4, 2017 •
edited by ghost
Loading

*This report has been truncated because the total content is 547482 characters in length, which is in excess of GitHub.com's limit for comments (65536 characters).

View the complete job log.

Firefox (nightly channel)

Testing web-platform-tests at revision 8e885f9
Using browser at version BuildID 20170404100210; SourceStamp b5d8b27a753725c1de41ffae2e338798f3b5cacd
Starting 10 test iterations
All results were stable

All results

98 tests ran
/XMLHttpRequest/event-readystatechange-loaded.htm
Subtest Results Messages
OK
XMLHttpRequest: the LOADING state change may be emitted multiple times PASS
/beacon/headers/header-referrer-no-referrer-when-downgrade.https.html
Subtest Results Messages
OK
Test referer header https://web-platform.test:8443/beacon/resources/ PASS
Test referer header http://web-platform.test:8000/beacon/resources/ FAIL assert_true: SendBeacon Succeeded expected true got false
/beacon/headers/header-referrer-no-referrer.html
Subtest Results Messages
OK
Test referer header /beacon/resources/ PASS
/beacon/headers/header-referrer-origin-when-cross-origin.html
Subtest Results Messages
OK
Test referer header http://web-platform.test:8000/beacon/resources/ PASS
Test referer header http://www1.web-platform.test:8000/beacon/resources/ PASS
/beacon/headers/header-referrer-origin.html
Subtest Results Messages
OK
Test referer header http://www1.web-platform.test:8000/beacon/resources/ PASS
/beacon/headers/header-referrer-same-origin.html
Subtest Results Messages
OK
Test referer header /beacon/resources/ PASS
Test referer header http://www1.web-platform.test:8000/beacon/resources/ PASS
/beacon/headers/header-referrer-strict-origin-when-cross-origin.https.html
Subtest Results Messages
OK
Test referer header https://web-platform.test:8443/beacon/resources/ PASS
Test referer header http://web-platform.test:8000/beacon/resources/ FAIL assert_true: SendBeacon Succeeded expected true got false
/beacon/headers/header-referrer-strict-origin.https.html
Subtest Results Messages
OK
Test referer header https://web-platform.test:8443/beacon/resources/ PASS
Test referer header http://web-platform.test:8000/beacon/resources/ FAIL assert_true: SendBeacon Succeeded expected true got false
/beacon/headers/header-referrer-unsafe-url.https.html
Subtest Results Messages
OK
Test referer header http://web-platform.test:8000/beacon/resources/ FAIL assert_true: SendBeacon Succeeded expected true got false
/css-timing-1/cubic-bezier-timing-functions-output.html
Subtest Results Messages
OK
cubic-bezier easing with input progress greater than 1 PASS
cubic-bezier easing with input progress greater than 1 and where the tangent on the upper boundary is infinity PASS
cubic-bezier easing with input progress less than 0 PASS
cubic-bezier easing with input progress less than 0 and where the tangent on the lower boundary is infinity PASS
/css-timing-1/frames-timing-functions-output.html
Subtest Results Messages
OK
For an input progress of 0.0, the output of a frames timing function is the first frame PASS
At a frame boundary, the output of a frames timing function is the next frame PASS
For an input progress of 1.0, the output of a frames timing function is the final frame PASS
The number of frames is correctly reflected in the frames timing function output PASS
The number of frames is correctly reflected in the frames timing function output on CSS Transitions PASS
frames easing with input progress greater than 1 PASS
frames easing with input progress greater than 1.5 PASS
frames easing with input progress less than 0 PASS
/css-timing-1/frames-timing-functions-syntax.html
Subtest Results Messages
OK
The number of frames must be a positive integer greater than 1, or we fallback to the previously-set easing PASS
The serialization of frames is 'frames(n)', n is the number of frames PASS
/css-timing-1/step-timing-functions-output.html
Subtest Results Messages
OK
step-start easing with input progress greater than 1 PASS
step-end easing with input progress greater than 1 PASS
step-end easing with input progress greater than 2 PASS
step-start easing with input progress less than 0 PASS
step-start easing with input progress less than -1 PASS
step-end easing with input progress less than 0 PASS
/css/css-grid-1/grid-items/grid-minimum-size-grid-items-021.html
Subtest Results Messages
OK
grid-1.width PASS
grid-1.height PASS
grid-1.gridTemplateColumns PASS
grid-1.gridTemplateRows PASS
img-1.width PASS
img-1.height PASS
grid-2.width PASS
grid-2.height PASS
grid-2.gridTemplateColumns PASS
grid-2.gridTemplateRows PASS
img-2.width PASS
img-2.height PASS
grid-3.width PASS
grid-3.height PASS
grid-3.gridTemplateColumns PASS
grid-3.gridTemplateRows PASS
img-3.width PASS
img-3.height PASS
grid-4.width PASS
grid-4.height PASS
grid-4.gridTemplateColumns PASS
grid-4.gridTemplateRows FAIL assert_equals: expected "50px" but got "10px"
img-4.width PASS
img-4.height PASS
grid-5.width PASS
grid-5.height PASS
grid-5.gridTemplateColumns PASS
grid-5.gridTemplateRows PASS
img-5.width PASS
img-5.height PASS
grid-6.width PASS
grid-6.height PASS
grid-6.gridTemplateColumns PASS
grid-6.gridTemplateRows FAIL assert_equals: expected "50px" but got "10px"
img-6.width PASS
img-6.height PASS
grid-7.width PASS
grid-7.height PASS
grid-7.gridTemplateColumns PASS
grid-7.gridTemplateRows PASS
img-7.width PASS
img-7.height PASS
grid-8.width PASS
grid-8.height PASS
grid-8.gridTemplateColumns PASS
grid-8.gridTemplateRows PASS
img-8.width PASS
img-8.height PASS
grid-9.width PASS
grid-9.height FAIL assert_equals: expected "125px" but got "75px"
grid-9.gridTemplateColumns PASS
grid-9.gridTemplateRows FAIL assert_equals: expected "100px 25px" but got "50px 25px"
img-9.width PASS
img-9.height PASS
grid-10.width PASS
grid-10.height PASS
grid-10.gridTemplateColumns PASS
grid-10.gridTemplateRows FAIL assert_equals: expected "50px 25px" but got "10px 25px"
img-10.width PASS
img-10.height PASS
grid-11.width PASS
grid-11.height FAIL assert_equals: expected "125px" but got "75px"
grid-11.gridTemplateColumns FAIL assert_equals: expected "100px" but got "71px"
grid-11.gridTemplateRows FAIL assert_equals: expected "100px 25px" but got "50px 25px"
img-11.width FAIL assert_equals: expected "100px" but got "71px"
img-11.height FAIL assert_equals: expected "100px" but got "71px"
grid-12.width PASS
grid-12.height PASS
grid-12.gridTemplateColumns FAIL assert_equals: expected "100px" but got "71px"
grid-12.gridTemplateRows FAIL assert_equals: expected "50px 25px" but got "10px 25px"
img-12.width FAIL assert_equals: expected "100px" but got "71px"
img-12.height FAIL assert_equals: expected "100px" but got "71px"
grid-13.width PASS
grid-13.height PASS
grid-13.gridTemplateColumns PASS
grid-13.gridTemplateRows PASS
img-13.width PASS
img-13.height PASS
grid-14.width PASS
grid-14.height PASS
grid-14.gridTemplateColumns PASS
grid-14.gridTemplateRows PASS
img-14.width PASS
img-14.height PASS
grid-15.width PASS
grid-15.height FAIL assert_equals: expected "200px" but got "500px"
grid-15.gridTemplateColumns PASS
grid-15.gridTemplateRows FAIL assert_equals: expected "200px" but got "500px"
img-15.width PASS
img-15.height PASS
grid-16.width PASS
grid-16.height PASS
grid-16.gridTemplateColumns PASS
grid-16.gridTemplateRows FAIL assert_equals: expected "200px" but got "10px"
img-16.width PASS
img-16.height PASS
grid-17.width PASS
grid-17.height FAIL assert_equals: expected "200px" but got "500px"
grid-17.gridTemplateColumns PASS
grid-17.gridTemplateRows FAIL assert_equals: expected "200px" but got "500px"
img-17.width PASS
img-17.height PASS
grid-18.width PASS
grid-18.height PASS
grid-18.gridTemplateColumns PASS
grid-18.gridTemplateRows FAIL assert_equals: expected "200px" but got "10px"
img-18.width PASS
img-18.height PASS
grid-19.width PASS
grid-19.height PASS
grid-19.gridTemplateColumns PASS
grid-19.gridTemplateRows PASS
img-19.width PASS
img-19.height PASS
grid-20.width PASS
grid-20.height PASS
grid-20.gridTemplateColumns PASS
grid-20.gridTemplateRows PASS
img-20.width PASS
img-20.height PASS
grid-21.width PASS
grid-21.height FAIL assert_equals: expected "225px" but got "525px"
grid-21.gridTemplateColumns PASS
grid-21.gridTemplateRows FAIL assert_equals: expected "200px 25px" but got "500px 25px"
img-21.width PASS
img-21.height PASS
grid-22.width PASS
grid-22.height PASS
grid-22.gridTemplateColumns PASS
grid-22.gridTemplateRows FAIL assert_equals: expected "200px 25px" but got "10px 25px"
img-22.width PASS
img-22.height PASS
grid-23.width PASS
grid-23.height FAIL assert_equals: expected "225px" but got "525px"
grid-23.gridTemplateColumns PASS
grid-23.gridTemplateRows FAIL assert_equals: expected "200px 25px" but got "500px 25px"
img-23.width PASS
img-23.height PASS
grid-24.width PASS
grid-24.height PASS
grid-24.gridTemplateColumns PASS
grid-24.gridTemplateRows FAIL assert_equals: expected "200px 25px" but got "10px 25px"
img-24.width PASS
img-24.height PASS
/dom/lists/DOMTokenList-iteration.html
Subtest Results Messages
OK
classList FAIL assert_array_equals: lengths differ, expected 2 got 3
classList.keys FAIL assert_array_equals: lengths differ, expected 2 got 3
classList.values FAIL assert_array_equals: lengths differ, expected 2 got 3
classList.entries PASS
classList.forEach PASS
classList inheritance from Array.prototype PASS
/geolocation-API/PositionOptions.https.html
Subtest Results Messages
TIMEOUT
Call getCurrentPosition with wrong type for enableHighAccuracy. No exception expected. PASS
Call watchPosition with wrong type for enableHighAccuracy. No exception expected. PASS
PositionOptions tests PASS
Set timeout and maximumAge to 0, check that timeout error raised (getCurrentPosition) NOTRUN
Set timeout and maximumAge to 0, check that timeout error raised (watchPosition) NOTRUN
Check that a negative timeout value is equivalent to a 0 timeout value (getCurrentLocation) NOTRUN
Check that a negative timeout value is equivalent to a 0 timeout value (watchPosition) NOTRUN
/geolocation-API/getCurrentPosition_IDL.https.html
Subtest Results Messages
TIMEOUT
getCurrentPosition success callback tests TIMEOUT Test timed out
getCurrentPosition error callback tests TIMEOUT Test timed out
/geolocation-API/getCurrentPosition_permission_allow.https.html
Subtest Results Messages
TIMEOUT
User allows access, check that success callback is called or error callback is called with correct code. NOTRUN
/geolocation-API/getCurrentPosition_permission_deny.https.html
Subtest Results Messages
TIMEOUT
User denies access, check that error callback is called with correct code TIMEOUT Test timed out
/geolocation-API/watchPosition_permission_deny.https.html
Subtest Results Messages
TIMEOUT
Check that watchPosition returns synchronously before any callbacks are invoked. NOTRUN
Check that watchPosition returns a long PASS
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html
Subtest Results Messages
OK
Basic sanity-checking PASS
Basic sanity-checking (exception type) PASS
Only whitelisted properties are accessible cross-origin PASS
Only whitelisted properties are accessible cross-origin (exception type) PASS
[[GetPrototypeOf]] should return null PASS
[[GetPrototypeOf]] should return null (exception type) PASS
[[SetPrototypeOf]] should return false PASS
[[SetPrototypeOf]] should return false (exception type) PASS
[[IsExtensible]] should return true for cross-origin objects PASS
[[IsExtensible]] should return true for cross-origin objects (exception type) PASS
[[PreventExtensions]] should throw for cross-origin objects PASS
[[PreventExtensions]] should throw for cross-origin objects (exception type) PASS
`[[GetOwnProperty]] - Properties on cross-origin objects should be reported own `
`[[GetOwnProperty]] - Properties on cross-origin objects should be reported own (exception type)`
[[GetOwnProperty]] - Property descriptors for cross-origin properties should be set up correctly PASS
[[GetOwnProperty]] - Property descriptors for cross-origin properties should be set up correctly (exception type) PASS
[[Delete]] Should throw on cross-origin objects PASS
[[Delete]] Should throw on cross-origin objects (exception type) PASS
[[DefineOwnProperty]] Should throw for cross-origin objects PASS
[[DefineOwnProperty]] Should throw for cross-origin objects (exception type) PASS
[[Enumerate]] should return an empty iterator PASS
[[Enumerate]] should return an empty iterator (exception type) PASS
[[OwnPropertyKeys]] should return all properties from cross-origin objects PASS
[[OwnPropertyKeys]] should return all properties from cross-origin objects (exception type) PASS
[[OwnPropertyKeys]] should return the right symbol-named properties for cross-origin objects PASS
[[OwnPropertyKeys]] should return the right symbol-named properties for cross-origin objects (exception type) PASS
[[OwnPropertyKeys]] should place the symbols after the property names after the subframe indices PASS
[[OwnPropertyKeys]] should place the symbols after the property names after the subframe indices (exception type) PASS
A and B jointly observe the same identity for cross-origin Window and Location PASS
A and B jointly observe the same identity for cross-origin Window and Location (exception type) PASS
Cross-origin functions get local Function.prototype PASS
Cross-origin functions get local Function.prototype (exception type) PASS
Cross-origin Window accessors get local Function.prototype PASS
Cross-origin Window accessors get local Function.prototype (exception type) PASS
Same-origin observers get different functions for cross-origin objects PASS
Same-origin observers get different functions for cross-origin objects (exception type) PASS
Same-origin observers get different accessors for cross-origin Window PASS
Same-origin observers get different accessors for cross-origin Window (exception type) PASS
Same-origin observers get different accessors for cross-origin Location PASS
Same-origin observers get different accessors for cross-origin Location (exception type) PASS
{}.toString.call() does the right thing on cross-origin objects PASS
{}.toString.call() does the right thing on cross-origin objects (exception type) PASS
/html/semantics/forms/textfieldselection/selection-start-end.html
Subtest Results Messages
OK
Sanity check for testValue length; if this fails, variou absolute offsets in the test below need to be adjusted to be less than testValue.length PASS
onselect should fire when selectionStart is changed PASS
onselect should fire when selectionStart is changed on input-appended PASS
onselect should fire when selectionStart is changed on input-not-appended PASS
onselect should fire when selectionStart is changed on input-appended-prefocused PASS
onselect should fire when selectionStart is changed on input-not-appended-prefocused PASS
onselect should fire when selectionStart is changed on textarea-appended PASS
onselect should fire when selectionStart is changed on textarea-not-appended PASS
onselect should fire when selectionStart is changed on textarea-appended-prefocused PASS
onselect should fire when selectionStart is changed on textarea-not-appended-prefocused PASS
onselect should fire when selectionEnd is changed PASS
onselect should fire when selectionEnd is changed on input-appended PASS
onselect should fire when selectionEnd is changed on input-not-appended PASS
onselect should fire when selectionEnd is changed on input-appended-prefocused PASS
onselect should fire when selectionEnd is changed on input-not-appended-prefocused PASS
onselect should fire when selectionEnd is changed on textarea-appended PASS
onselect should fire when selectionEnd is changed on textarea-not-appended PASS
onselect should fire when selectionEnd is changed on textarea-appended-prefocused PASS
onselect should fire when selectionEnd is changed on textarea-not-appended-prefocused PASS
Setting selectionStart to a value larger than selectionEnd should increase selectionEnd PASS
Setting selectionEnd to a value smaller than selectionStart should decrease selectionStart PASS
selectionStart edge-case values PASS
selectionEnd edge-case values PASS
/html/semantics/forms/textfieldselection/selection-value-interactions.html
Subtest Results Messages
OK
value dirty flag behavior after setRangeText on textarea not in body PASS
value dirty flag behavior after setRangeText on input not in body PASS
value dirty flag behavior after setRangeText on textarea in body PASS
value dirty flag behavior after setRangeText on input in body PASS
value dirty flag behavior after setRangeText on textarea in body with parsed default value PASS
value dirty flag behavior after setRangeText on input in body with parsed default value PASS
value dirty flag behavior after setRangeText on focused textarea PASS
value dirty flag behavior after setRangeText on focused input PASS
value dirty flag behavior after setRangeText on focused then blurred textarea PASS
value dirty flag behavior after setRangeText on focused then blurred input PASS
/html/semantics/forms/textfieldselection/selection.html
Subtest Results Messages
OK
test if selection text is correct for input PASS
test if selection text is correct for textarea PASS
test if non-ascii selection text is correct for input PASS
test if non-ascii selection text is correct for textarea PASS
test SelectionStart offset for input that is appended PASS
test SelectionStart offset for input that is not appended PASS
test SelectionStart offset for textarea that is appended PASS
test SelectionStart offset for textarea that is not appended PASS
test SelectionEnd offset for input that is appended PASS
test SelectionEnd offset for input that is not appended PASS
test SelectionEnd offset for textarea that is appended PASS
test SelectionEnd offset for textarea that is not appended PASS
test SelectionDirection for input PASS
test SelectionDirection for textarea PASS
/html/semantics/forms/textfieldselection/textfieldselection-setRangeText.html
Subtest Results Messages
OK
text setRangeText with only one argument replaces the value between selectionStart and selectionEnd, otherwise replaces the value between 2nd and 3rd arguments PASS
text selectionMode missing PASS
text selectionMode 'select' PASS
text selectionMode 'start' PASS
text selectionMode 'end' PASS
text selectionMode 'preserve' PASS
text setRangeText with 3rd argument greater than 2nd argument throws an IndexSizeError exception PASS
text setRangeText without argument throws a type error PASS
text setRangeText fires a select event PASS
search setRangeText with only one argument replaces the value between selectionStart and selectionEnd, otherwise replaces the value between 2nd and 3rd arguments PASS
search selectionMode missing PASS
search selectionMode 'select' PASS
search selectionMode 'start' PASS
search selectionMode 'end' PASS
search selectionMode 'preserve' PASS
search setRangeText with 3rd argument greater than 2nd argument throws an IndexSizeError exception PASS
search setRangeText without argument throws a type error PASS
search setRangeText fires a select event PASS
tel setRangeText with only one argument replaces the value between selectionStart and selectionEnd, otherwise replaces the value between 2nd and 3rd arguments PASS
tel selectionMode missing PASS
tel selectionMode 'select' PASS
tel selectionMode 'start' PASS
tel selectionMode 'end' PASS
tel selectionMode 'preserve' PASS
tel setRangeText with 3rd argument greater than 2nd argument throws an IndexSizeError exception PASS
tel setRangeText without argument throws a type error PASS
tel setRangeText fires a select event PASS
url setRangeText with only one argument replaces the value between selectionStart and selectionEnd, otherwise replaces the value between 2nd and 3rd arguments PASS
url selectionMode missing PASS
url selectionMode 'select' PASS
url selectionMode 'start' PASS
url selectionMode 'end' PASS
url selectionMode 'preserve' PASS
url setRangeText with 3rd argument greater than 2nd argument throws an IndexSizeError exception PASS
url setRangeText without argument throws a type error PASS
url setRangeText fires a select event PASS
password setRangeText with only one argument replaces the value between selectionStart and selectionEnd, otherwise replaces the value between 2nd and 3rd arguments PASS
password selectionMode missing PASS
password selectionMode 'select' PASS
password selectionMode 'start' PASS
password selectionMode 'end' PASS
password selectionMode 'preserve' PASS
password setRangeText with 3rd argument greater than 2nd argument throws an IndexSizeError exception PASS
password setRangeText without argument throws a type error PASS
password setRangeText fires a select event PASS
display_none setRangeText with only one argument replaces the value between selectionStart and selectionEnd, otherwise replaces the value between 2nd and 3rd arguments PASS
display_none selectionMode missing PASS
display_none selectionMode 'select' PASS
display_none selectionMode 'start' PASS
display_none selectionMode 'end' PASS
display_none selectionMode 'preserve' PASS
display_none setRangeText with 3rd argument greater than 2nd argument throws an IndexSizeError exception PASS
display_none setRangeText without argument throws a type error PASS
display_none setRangeText fires a select event PASS
textarea setRangeText with only one argument replaces the value between selectionStart and selectionEnd, otherwise replaces the value between 2nd and 3rd arguments PASS
textarea selectionMode missing PASS
textarea selectionMode 'select' PASS
textarea selectionMode 'start' PASS
textarea selectionMode 'end' PASS
textarea selectionMode 'preserve' PASS
textarea setRangeText with 3rd argument greater than 2nd argument throws an IndexSizeError exception PASS
textarea setRangeText without argument throws a type error PASS
textarea setRangeText fires a select event PASS
input_not_in_doc setRangeText with only one argument replaces the value between selectionStart and selectionEnd, otherwise replaces the value between 2nd and 3rd arguments PASS
input_not_in_doc selectionMode missing PASS
input_not_in_doc selectionMode 'select' PASS
input_not_in_doc selectionMode 'start' PASS
input_not_in_doc selectionMode 'end' PASS
input_not_in_doc selectionMode 'preserve' PASS
input_not_in_doc setRangeText with 3rd argument greater than 2nd argument throws an IndexSizeError exception PASS
input_not_in_doc setRangeText without argument throws a type error PASS
input_not_in_doc setRangeText fires a select event PASS
/html/semantics/forms/textfieldselection/textfieldselection-setSelectionRange.html
Subtest Results Messages
OK
test of input.setSelectionRange PASS
input typeof(input.setSelectionRange)' PASS
input setSelectionRange return void PASS
input setSelectionRange(0,1) PASS
input setSelectionRange(0,input.value.length+1) PASS
input setSelectionRange(input.value.length+1,input.value.length+1) PASS
input setSelectionRange(input.value.length+1,1) PASS

@ghost
Copy link

ghost commented Apr 4, 2017 •
edited by ghost
Loading

*This report has been truncated because the total content is 1350566 characters in length, which is in excess of GitHub.com's limit for comments (65536 characters).

View the complete job log.

Chrome (unstable channel)

Testing web-platform-tests at revision 8e885f9
Using browser at version 59.0.3053.3 dev
Starting 10 test iterations

Unstable results

Test Subtest Results Messages
/geolocation-API/getCurrentPosition_permission_deny.https.html User denies access, check that error callback is called with correct code TIMEOUT: 3/10, MISSING: 7/10 Test timed out
/geolocation-API/watchPosition_permission_deny.https.html TIMEOUT: 3/10, MISSING: 7/10
/geolocation-API/watchPosition_permission_deny.https.html Check that watchPosition returns synchronously before any callbacks are invoked. NOTRUN: 2/10, MISSING: 8/10
/geolocation-API/watchPosition_permission_deny.https.html Check that watchPosition returns a long PASS: 2/10, MISSING: 8/10
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html OK: 2/10, MISSING: 8/10
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html Basic sanity-checking PASS: 2/10, MISSING: 8/10
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html Basic sanity-checking (exception type) PASS: 2/10, MISSING: 8/10
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html Only whitelisted properties are accessible cross-origin PASS: 2/10, MISSING: 8/10
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html Only whitelisted properties are accessible cross-origin (exception type) PASS: 2/10, MISSING: 8/10
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html [[GetPrototypeOf]] should return null PASS: 2/10, MISSING: 8/10
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html [[GetPrototypeOf]] should return null (exception type) PASS: 2/10, MISSING: 8/10
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html [[SetPrototypeOf]] should return false FAIL: 2/10, MISSING: 8/10 Blocked a frame with origin "http://web-platform.test:8000" from accessing a cross-origin frame.
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html [[SetPrototypeOf]] should return false (exception type) FAIL: 2/10, MISSING: 8/10 `assert_throws: proto setter
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html [[IsExtensible]] should return true for cross-origin objects PASS: 2/10, MISSING: 8/10
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html [[IsExtensible]] should return true for cross-origin objects (exception type) PASS: 2/10, MISSING: 8/10
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html [[PreventExtensions]] should throw for cross-origin objects PASS: 2/10, MISSING: 8/10
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html [[PreventExtensions]] should throw for cross-origin objects (exception type) FAIL: 2/10, MISSING: 8/10 assert_throws: preventExtensions on cross-origin Window should throw function "function () { Object.preventExtensions(C) }" threw object "SecurityError: Blocked a frame with origin "http://web-platform.test:8000" from accessing a cross-origin frame." ("SecurityError") expected object "TypeError" ("TypeError")
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html `[[GetOwnProperty]] - Properties on cross-origin objects should be reported own `
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html `[[GetOwnProperty]] - Properties on cross-origin objects should be reported own (exception type)`
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html [[GetOwnProperty]] - Property descriptors for cross-origin properties should be set up correctly FAIL: 2/10, MISSING: 8/10 assert_equals: property descriptor for 0 should have writable: false expected false but got true
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html [[GetOwnProperty]] - Property descriptors for cross-origin properties should be set up correctly (exception type) FAIL: 2/10, MISSING: 8/10 assert_unreached: Main test failed Reached unreachable code
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html [[Delete]] Should throw on cross-origin objects PASS: 2/10, MISSING: 8/10
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html [[Delete]] Should throw on cross-origin objects (exception type) PASS: 2/10, MISSING: 8/10
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html [[DefineOwnProperty]] Should throw for cross-origin objects PASS: 2/10, MISSING: 8/10
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html [[DefineOwnProperty]] Should throw for cross-origin objects (exception type) PASS: 2/10, MISSING: 8/10
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html [[Enumerate]] should return an empty iterator PASS: 2/10, MISSING: 8/10
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html [[Enumerate]] should return an empty iterator (exception type) PASS: 2/10, MISSING: 8/10
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html [[OwnPropertyKeys]] should return all properties from cross-origin objects FAIL: 2/10, MISSING: 8/10 assert_array_equals: Object.getOwnPropertyNames() gives the right answer for cross-origin Window lengths differ, expected 15 got 13
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html [[OwnPropertyKeys]] should return all properties from cross-origin objects (exception type) FAIL: 2/10, MISSING: 8/10 assert_unreached: Main test failed Reached unreachable code
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html [[OwnPropertyKeys]] should return the right symbol-named properties for cross-origin objects FAIL: 2/10, MISSING: 8/10 assert_array_equals: Object.getOwnPropertySymbols() should return the three symbol-named properties that are exposed on a cross-origin Window lengths differ, expected 3 got 0
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html [[OwnPropertyKeys]] should return the right symbol-named properties for cross-origin objects (exception type) FAIL: 2/10, MISSING: 8/10 assert_unreached: Main test failed Reached unreachable code
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html [[OwnPropertyKeys]] should place the symbols after the property names after the subframe indices FAIL: 2/10, MISSING: 8/10 assert_array_equals: Reflect.ownKeys should start with the indices exposed on the cross-origin window. property 0, expected "0" but got "window"
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html [[OwnPropertyKeys]] should place the symbols after the property names after the subframe indices (exception type) FAIL: 2/10, MISSING: 8/10 assert_unreached: Main test failed Reached unreachable code
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html A and B jointly observe the same identity for cross-origin Window and Location PASS: 2/10, MISSING: 8/10
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html A and B jointly observe the same identity for cross-origin Window and Location (exception type) PASS: 2/10, MISSING: 8/10
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html Cross-origin functions get local Function.prototype PASS: 2/10, MISSING: 8/10
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html Cross-origin functions get local Function.prototype (exception type) PASS: 2/10, MISSING: 8/10
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html Cross-origin Window accessors get local Function.prototype FAIL: 2/10, MISSING: 8/10 Cannot read property 'name' of undefined
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html Cross-origin Window accessors get local Function.prototype (exception type) FAIL: 2/10, MISSING: 8/10 assert_unreached: Main test failed Reached unreachable code
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html Same-origin observers get different functions for cross-origin objects FAIL: 2/10, MISSING: 8/10 assert_true: same-origin Window functions get their own object expected true got false
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html Same-origin observers get different functions for cross-origin objects (exception type) FAIL: 2/10, MISSING: 8/10 assert_unreached: Main test failed Reached unreachable code
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html Same-origin observers get different accessors for cross-origin Window FAIL: 2/10, MISSING: 8/10 assert_true: different Window accessors per-incumbent script settings object expected true got false
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html Same-origin observers get different accessors for cross-origin Window (exception type) FAIL: 2/10, MISSING: 8/10 assert_unreached: Main test failed Reached unreachable code
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html Same-origin observers get different accessors for cross-origin Location FAIL: 2/10, MISSING: 8/10 Blocked a frame with origin "http://web-platform.test:8000" from accessing a cross-origin frame.
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html Same-origin observers get different accessors for cross-origin Location (exception type) FAIL: 2/10, MISSING: 8/10 assert_unreached: Main test failed Reached unreachable code
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html {}.toString.call() does the right thing on cross-origin objects FAIL: 2/10, MISSING: 8/10 assert_equals: expected "[object Object]" but got "[object Location]"
/html/browsers/origin/cross-origin-objects/cross-origin-objects.html {}.toString.call() does the right thing on cross-origin objects (exception type) FAIL: 2/10, MISSING: 8/10 assert_unreached: Main test failed Reached unreachable code
/html/semantics/forms/textfieldselection/selection-start-end.html OK: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection-start-end.html Sanity check for testValue length; if this fails, variou absolute offsets in the test below need to be adjusted to be less than testValue.length PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection-start-end.html onselect should fire when selectionStart is changed PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection-start-end.html onselect should fire when selectionStart is changed on input-appended PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection-start-end.html onselect should fire when selectionStart is changed on input-not-appended PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection-start-end.html onselect should fire when selectionStart is changed on input-appended-prefocused PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection-start-end.html onselect should fire when selectionStart is changed on input-not-appended-prefocused PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection-start-end.html onselect should fire when selectionStart is changed on textarea-appended PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection-start-end.html onselect should fire when selectionStart is changed on textarea-not-appended PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection-start-end.html onselect should fire when selectionStart is changed on textarea-appended-prefocused PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection-start-end.html onselect should fire when selectionStart is changed on textarea-not-appended-prefocused PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection-start-end.html onselect should fire when selectionEnd is changed PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection-start-end.html onselect should fire when selectionEnd is changed on input-appended PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection-start-end.html onselect should fire when selectionEnd is changed on input-not-appended PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection-start-end.html onselect should fire when selectionEnd is changed on input-appended-prefocused PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection-start-end.html onselect should fire when selectionEnd is changed on input-not-appended-prefocused PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection-start-end.html onselect should fire when selectionEnd is changed on textarea-appended PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection-start-end.html onselect should fire when selectionEnd is changed on textarea-not-appended PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection-start-end.html onselect should fire when selectionEnd is changed on textarea-appended-prefocused PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection-start-end.html onselect should fire when selectionEnd is changed on textarea-not-appended-prefocused PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection-start-end.html Setting selectionStart to a value larger than selectionEnd should increase selectionEnd PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection-start-end.html Setting selectionEnd to a value smaller than selectionStart should decrease selectionStart PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection-start-end.html selectionStart edge-case values PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection-start-end.html selectionEnd edge-case values PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection-value-interactions.html OK: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection-value-interactions.html value dirty flag behavior after setRangeText on textarea not in body PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection-value-interactions.html value dirty flag behavior after setRangeText on input not in body PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection-value-interactions.html value dirty flag behavior after setRangeText on textarea in body PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection-value-interactions.html value dirty flag behavior after setRangeText on input in body PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection-value-interactions.html value dirty flag behavior after setRangeText on textarea in body with parsed default value PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection-value-interactions.html value dirty flag behavior after setRangeText on input in body with parsed default value PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection-value-interactions.html value dirty flag behavior after setRangeText on focused textarea PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection-value-interactions.html value dirty flag behavior after setRangeText on focused input PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection-value-interactions.html value dirty flag behavior after setRangeText on focused then blurred textarea PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection-value-interactions.html value dirty flag behavior after setRangeText on focused then blurred input PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection.html OK: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection.html test if selection text is correct for input PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection.html test if selection text is correct for textarea PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection.html test if non-ascii selection text is correct for input PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection.html test if non-ascii selection text is correct for textarea PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection.html test SelectionStart offset for input that is appended PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection.html test SelectionStart offset for input that is not appended PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection.html test SelectionStart offset for textarea that is appended PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection.html test SelectionStart offset for textarea that is not appended PASS: 2/10, MISSING: 8/10
/html/semantics/forms/textfieldselection/selection.html test SelectionEnd offset for input that is appended PASS: 2/10, MISSING: 8/10

@mrego
Copy link
Member Author

mrego commented Apr 4, 2017

I'm using Chrome 59.0.3053.3 and the test passes locally.
In Firefox it's expected to fail as the implementation is different there (see bug).

@svillar
Copy link
Contributor

svillar commented Apr 4, 2017

@mrego: I understood that the current spec text is going to be changed, why do you say the current text is correct?

@gsnedders
Copy link
Member

@mrego The problem isn't the failure, it's the inconsistent in the results in both Firefox and Chrome.

As I said before, I think this is to do with image loading. Consider:

<div id="grid-1" class="grid">
  <img id="img-1" class="width200px" src="support/50x50-green.png">
</div>

This is parsed, and a request for support/50x50-green.png is initiated.

<script>
  checkGridSizeTracksAndImageSize("grid-1", "img-1", "200px", "200px", "200px", "200px", "200px", "200px");
</script>

This script is then parsed and run, leading to it fail because #img-1's computed style is the default width/height of an unloaded image.

The image then loads, but it's too late because the test has already run. This is why I think its results are random in both Firefox and Chrome.

There's a race condition in here and that needs dealt with (with the load event and complete property).

@mrego
Copy link
Member Author

mrego commented Apr 4, 2017

@mrego: I understood that the current spec text is going to be changed, why do you say the current text is correct?

I meant that this test is currently right, until the spec is not modified. That should happen soon, but we never know when it's going to happen exactly. So I was wondering if it'd make sense to merge this first and later update it once the spec is modified. Waiting for the spec to be revised works for me too.

@mrego The problem isn't the failure, it's the inconsistent in the results in both Firefox and Chrome.

Yeah sorry I was not getting it, it's clear there are issues with the test, I'll try to get them fixed. Thanks!

@ghost
Copy link

ghost commented Apr 4, 2017

These tests are now available on w3c-test.org

@gsnedders
Copy link
Member

opened #5408 for the Travis failure

@mrego mrego force-pushed the css-grid-test-minimum-size-image branch from 9c3117c to 91ab32a Compare May 24, 2017 20:55
@ghost
Copy link

ghost commented May 24, 2017 •
edited by ghost
Loading

View the complete job log.

Firefox (nightly)

Testing web-platform-tests at revision c1ca5ae
Using browser at version BuildID 20170524100215; SourceStamp 291a11111bdd05c5cd55dd552da4b1285ceba9b2
Starting 10 test iterations
All results were stable

All results

1 test ran
/css/css-grid-1/grid-items/grid-minimum-size-grid-items-021.html
Subtest Results Messages
OK
grid-1.width PASS
grid-1.height PASS
grid-1.gridTemplateColumns PASS
grid-1.gridTemplateRows PASS
img-1.width PASS
img-1.height PASS
grid-2.width PASS
grid-2.height PASS
grid-2.gridTemplateColumns PASS
grid-2.gridTemplateRows PASS
img-2.width PASS
img-2.height PASS
grid-3.width PASS
grid-3.height FAIL assert_equals: expected "50px" but got "200px"
grid-3.gridTemplateColumns PASS
grid-3.gridTemplateRows FAIL assert_equals: expected "50px" but got "200px"
img-3.width PASS
img-3.height PASS
grid-4.width PASS
grid-4.height PASS
grid-4.gridTemplateColumns PASS
grid-4.gridTemplateRows PASS
img-4.width PASS
img-4.height PASS
grid-5.width PASS
grid-5.height PASS
grid-5.gridTemplateColumns PASS
grid-5.gridTemplateRows PASS
img-5.width PASS
img-5.height PASS
grid-6.width PASS
grid-6.height PASS
grid-6.gridTemplateColumns PASS
grid-6.gridTemplateRows PASS
img-6.width PASS
img-6.height PASS
grid-7.width PASS
grid-7.height PASS
grid-7.gridTemplateColumns PASS
grid-7.gridTemplateRows PASS
img-7.width PASS
img-7.height PASS
grid-8.width PASS
grid-8.height PASS
grid-8.gridTemplateColumns PASS
grid-8.gridTemplateRows PASS
img-8.width PASS
img-8.height PASS
grid-9.width PASS
grid-9.height FAIL assert_equals: expected "125px" but got "225px"
grid-9.gridTemplateColumns PASS
grid-9.gridTemplateRows FAIL assert_equals: expected "100px 25px" but got "200px 25px"
img-9.width PASS
img-9.height PASS
grid-10.width PASS
grid-10.height PASS
grid-10.gridTemplateColumns PASS
grid-10.gridTemplateRows PASS
img-10.width PASS
img-10.height PASS
grid-11.width PASS
grid-11.height FAIL assert_equals: expected "125px" but got "96px"
grid-11.gridTemplateColumns FAIL assert_equals: expected "100px" but got "71px"
grid-11.gridTemplateRows FAIL assert_equals: expected "100px 25px" but got "71px 25px"
img-11.width FAIL assert_equals: expected "100px" but got "71px"
img-11.height FAIL assert_equals: expected "100px" but got "71px"
grid-12.width PASS
grid-12.height PASS
grid-12.gridTemplateColumns FAIL assert_equals: expected "100px" but got "71px"
grid-12.gridTemplateRows PASS
img-12.width FAIL assert_equals: expected "100px" but got "71px"
img-12.height FAIL assert_equals: expected "100px" but got "71px"
grid-13.width PASS
grid-13.height PASS
grid-13.gridTemplateColumns PASS
grid-13.gridTemplateRows PASS
img-13.width PASS
img-13.height PASS
grid-14.width PASS
grid-14.height PASS
grid-14.gridTemplateColumns PASS
grid-14.gridTemplateRows PASS
img-14.width PASS
img-14.height PASS
grid-15.width PASS
grid-15.height PASS
grid-15.gridTemplateColumns PASS
grid-15.gridTemplateRows PASS
img-15.width PASS
img-15.height PASS
grid-16.width PASS
grid-16.height PASS
grid-16.gridTemplateColumns PASS
grid-16.gridTemplateRows PASS
img-16.width PASS
img-16.height PASS
grid-17.width PASS
grid-17.height PASS
grid-17.gridTemplateColumns PASS
grid-17.gridTemplateRows PASS
img-17.width PASS
img-17.height PASS
grid-18.width PASS
grid-18.height PASS
grid-18.gridTemplateColumns PASS
grid-18.gridTemplateRows PASS
img-18.width PASS
img-18.height PASS
grid-19.width PASS
grid-19.height PASS
grid-19.gridTemplateColumns PASS
grid-19.gridTemplateRows PASS
img-19.width PASS
img-19.height PASS
grid-20.width PASS
grid-20.height PASS
grid-20.gridTemplateColumns PASS
grid-20.gridTemplateRows PASS
img-20.width PASS
img-20.height PASS
grid-21.width PASS
grid-21.height PASS
grid-21.gridTemplateColumns PASS
grid-21.gridTemplateRows PASS
img-21.width PASS
img-21.height PASS
grid-22.width PASS
grid-22.height PASS
grid-22.gridTemplateColumns PASS
grid-22.gridTemplateRows PASS
img-22.width PASS
img-22.height PASS
grid-23.width PASS
grid-23.height PASS
grid-23.gridTemplateColumns PASS
grid-23.gridTemplateRows PASS
img-23.width PASS
img-23.height PASS
grid-24.width PASS
grid-24.height PASS
grid-24.gridTemplateColumns PASS
grid-24.gridTemplateRows PASS
img-24.width PASS
img-24.height PASS

@ghost
Copy link

ghost commented May 24, 2017 •
edited by ghost
Loading

View the complete job log.

Sauce (safari)

Testing web-platform-tests at revision c1ca5ae
Using browser at version 10.0
Starting 10 test iterations
All results were stable

All results

1 test ran
/css/css-grid-1/grid-items/grid-minimum-size-grid-items-021.html
Subtest Results Messages
OK
grid-1.width FAIL assert_equals: expected "200px" but got "784px"
grid-1.height FAIL assert_equals: expected "200px" but got "204px"
grid-1.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-1.gridTemplateRows FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
img-1.width PASS
img-1.height PASS
grid-2.width PASS
grid-2.height PASS
grid-2.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-2.gridTemplateRows FAIL assert_equals: expected (string) "50px" but got (undefined) undefined
img-2.width PASS
img-2.height PASS
grid-3.width PASS
grid-3.height FAIL assert_equals: expected "50px" but got "204px"
grid-3.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-3.gridTemplateRows FAIL assert_equals: expected (string) "50px" but got (undefined) undefined
img-3.width PASS
img-3.height PASS
grid-4.width PASS
grid-4.height PASS
grid-4.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-4.gridTemplateRows FAIL assert_equals: expected (string) "50px" but got (undefined) undefined
img-4.width PASS
img-4.height PASS
grid-5.width PASS
grid-5.height FAIL assert_equals: expected "50px" but got "204px"
grid-5.gridTemplateColumns FAIL assert_equals: expected (string) "50px" but got (undefined) undefined
grid-5.gridTemplateRows FAIL assert_equals: expected (string) "50px" but got (undefined) undefined
img-5.width FAIL assert_equals: expected "50px" but got "200px"
img-5.height FAIL assert_equals: expected "50px" but got "200px"
grid-6.width PASS
grid-6.height PASS
grid-6.gridTemplateColumns FAIL assert_equals: expected (string) "50px" but got (undefined) undefined
grid-6.gridTemplateRows FAIL assert_equals: expected (string) "50px" but got (undefined) undefined
img-6.width FAIL assert_equals: expected "50px" but got "200px"
img-6.height FAIL assert_equals: expected "50px" but got "200px"
grid-7.width FAIL assert_equals: expected "200px" but got "784px"
grid-7.height FAIL assert_equals: expected "225px" but got "229px"
grid-7.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-7.gridTemplateRows FAIL assert_equals: expected (string) "200px 25px" but got (undefined) undefined
img-7.width PASS
img-7.height PASS
grid-8.width PASS
grid-8.height PASS
grid-8.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-8.gridTemplateRows FAIL assert_equals: expected (string) "50px 25px" but got (undefined) undefined
img-8.width PASS
img-8.height PASS
grid-9.width PASS
grid-9.height FAIL assert_equals: expected "125px" but got "229px"
grid-9.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-9.gridTemplateRows FAIL assert_equals: expected (string) "100px 25px" but got (undefined) undefined
img-9.width PASS
img-9.height PASS
grid-10.width PASS
grid-10.height PASS
grid-10.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-10.gridTemplateRows FAIL assert_equals: expected (string) "50px 25px" but got (undefined) undefined
img-10.width PASS
img-10.height PASS
grid-11.width PASS
grid-11.height FAIL assert_equals: expected "125px" but got "229px"
grid-11.gridTemplateColumns FAIL assert_equals: expected (string) "100px" but got (undefined) undefined
grid-11.gridTemplateRows FAIL assert_equals: expected (string) "100px 25px" but got (undefined) undefined
img-11.width FAIL assert_equals: expected "100px" but got "200px"
img-11.height FAIL assert_equals: expected "100px" but got "200px"
grid-12.width PASS
grid-12.height PASS
grid-12.gridTemplateColumns FAIL assert_equals: expected (string) "100px" but got (undefined) undefined
grid-12.gridTemplateRows FAIL assert_equals: expected (string) "50px 25px" but got (undefined) undefined
img-12.width FAIL assert_equals: expected "100px" but got "200px"
img-12.height FAIL assert_equals: expected "100px" but got "200px"
grid-13.width FAIL assert_equals: expected "200px" but got "784px"
grid-13.height FAIL assert_equals: expected "200px" but got "204px"
grid-13.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-13.gridTemplateRows FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
img-13.width PASS
img-13.height PASS
grid-14.width PASS
grid-14.height PASS
grid-14.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-14.gridTemplateRows FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
img-14.width PASS
img-14.height PASS
grid-15.width PASS
grid-15.height FAIL assert_equals: expected "200px" but got "204px"
grid-15.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-15.gridTemplateRows FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
img-15.width PASS
img-15.height PASS
grid-16.width PASS
grid-16.height PASS
grid-16.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-16.gridTemplateRows FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
img-16.width PASS
img-16.height PASS
grid-17.width PASS
grid-17.height FAIL assert_equals: expected "200px" but got "204px"
grid-17.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-17.gridTemplateRows FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
img-17.width PASS
img-17.height PASS
grid-18.width PASS
grid-18.height PASS
grid-18.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-18.gridTemplateRows FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
img-18.width PASS
img-18.height PASS
grid-19.width FAIL assert_equals: expected "200px" but got "784px"
grid-19.height FAIL assert_equals: expected "225px" but got "229px"
grid-19.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-19.gridTemplateRows FAIL assert_equals: expected (string) "200px 25px" but got (undefined) undefined
img-19.width PASS
img-19.height PASS
grid-20.width PASS
grid-20.height PASS
grid-20.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-20.gridTemplateRows FAIL assert_equals: expected (string) "200px 25px" but got (undefined) undefined
img-20.width PASS
img-20.height PASS
grid-21.width PASS
grid-21.height FAIL assert_equals: expected "225px" but got "229px"
grid-21.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-21.gridTemplateRows FAIL assert_equals: expected (string) "200px 25px" but got (undefined) undefined
img-21.width PASS
img-21.height PASS
grid-22.width PASS
grid-22.height PASS
grid-22.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-22.gridTemplateRows FAIL assert_equals: expected (string) "200px 25px" but got (undefined) undefined
img-22.width PASS
img-22.height PASS
grid-23.width PASS
grid-23.height FAIL assert_equals: expected "225px" but got "229px"
grid-23.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-23.gridTemplateRows FAIL assert_equals: expected (string) "200px 25px" but got (undefined) undefined
img-23.width PASS
img-23.height PASS
grid-24.width PASS
grid-24.height PASS
grid-24.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-24.gridTemplateRows FAIL assert_equals: expected (string) "200px 25px" but got (undefined) undefined
img-24.width PASS
img-24.height PASS

@ghost
Copy link

ghost commented May 24, 2017 •
edited by ghost
Loading

View the complete job log.

Chrome (unstable)

Testing web-platform-tests at revision c1ca5ae
Using browser at version 60.0.3107.4 dev
Starting 10 test iterations
All results were stable

All results

1 test ran
/css/css-grid-1/grid-items/grid-minimum-size-grid-items-021.html
Subtest Results Messages
OK
grid-1.width PASS
grid-1.height PASS
grid-1.gridTemplateColumns PASS
grid-1.gridTemplateRows PASS
img-1.width PASS
img-1.height PASS
grid-2.width PASS
grid-2.height PASS
grid-2.gridTemplateColumns PASS
grid-2.gridTemplateRows PASS
img-2.width PASS
img-2.height PASS
grid-3.width PASS
grid-3.height PASS
grid-3.gridTemplateColumns PASS
grid-3.gridTemplateRows PASS
img-3.width PASS
img-3.height PASS
grid-4.width PASS
grid-4.height PASS
grid-4.gridTemplateColumns PASS
grid-4.gridTemplateRows PASS
img-4.width PASS
img-4.height PASS
grid-5.width PASS
grid-5.height PASS
grid-5.gridTemplateColumns PASS
grid-5.gridTemplateRows PASS
img-5.width PASS
img-5.height PASS
grid-6.width PASS
grid-6.height PASS
grid-6.gridTemplateColumns PASS
grid-6.gridTemplateRows PASS
img-6.width PASS
img-6.height PASS
grid-7.width PASS
grid-7.height PASS
grid-7.gridTemplateColumns PASS
grid-7.gridTemplateRows PASS
img-7.width PASS
img-7.height PASS
grid-8.width PASS
grid-8.height PASS
grid-8.gridTemplateColumns PASS
grid-8.gridTemplateRows PASS
img-8.width PASS
img-8.height PASS
grid-9.width PASS
grid-9.height FAIL assert_equals: expected "125px" but got "86.1094px"
grid-9.gridTemplateColumns PASS
grid-9.gridTemplateRows FAIL assert_equals: expected "100px 25px" but got "61.1094px 25px"
img-9.width PASS
img-9.height PASS
grid-10.width PASS
grid-10.height PASS
grid-10.gridTemplateColumns PASS
grid-10.gridTemplateRows PASS
img-10.width PASS
img-10.height PASS
grid-11.width PASS
grid-11.height FAIL assert_equals: expected "125px" but got "86.1094px"
grid-11.gridTemplateColumns FAIL assert_equals: expected "100px" but got "61.1094px"
grid-11.gridTemplateRows FAIL assert_equals: expected "100px 25px" but got "61.1094px 25px"
img-11.width FAIL assert_equals: expected "100px" but got "61.1094px"
img-11.height FAIL assert_equals: expected "100px" but got "61.1094px"
grid-12.width PASS
grid-12.height PASS
grid-12.gridTemplateColumns FAIL assert_equals: expected "100px" but got "61.1094px"
grid-12.gridTemplateRows PASS
img-12.width FAIL assert_equals: expected "100px" but got "61.1094px"
img-12.height FAIL assert_equals: expected "100px" but got "61.1094px"
grid-13.width PASS
grid-13.height PASS
grid-13.gridTemplateColumns PASS
grid-13.gridTemplateRows PASS
img-13.width PASS
img-13.height PASS
grid-14.width PASS
grid-14.height PASS
grid-14.gridTemplateColumns PASS
grid-14.gridTemplateRows PASS
img-14.width PASS
img-14.height PASS
grid-15.width PASS
grid-15.height PASS
grid-15.gridTemplateColumns PASS
grid-15.gridTemplateRows PASS
img-15.width PASS
img-15.height PASS
grid-16.width PASS
grid-16.height PASS
grid-16.gridTemplateColumns PASS
grid-16.gridTemplateRows PASS
img-16.width PASS
img-16.height PASS
grid-17.width PASS
grid-17.height PASS
grid-17.gridTemplateColumns PASS
grid-17.gridTemplateRows PASS
img-17.width PASS
img-17.height PASS
grid-18.width PASS
grid-18.height PASS
grid-18.gridTemplateColumns PASS
grid-18.gridTemplateRows PASS
img-18.width PASS
img-18.height PASS
grid-19.width PASS
grid-19.height PASS
grid-19.gridTemplateColumns PASS
grid-19.gridTemplateRows PASS
img-19.width PASS
img-19.height PASS
grid-20.width PASS
grid-20.height PASS
grid-20.gridTemplateColumns PASS
grid-20.gridTemplateRows PASS
img-20.width PASS
img-20.height PASS
grid-21.width PASS
grid-21.height PASS
grid-21.gridTemplateColumns PASS
grid-21.gridTemplateRows PASS
img-21.width PASS
img-21.height PASS
grid-22.width PASS
grid-22.height PASS
grid-22.gridTemplateColumns PASS
grid-22.gridTemplateRows PASS
img-22.width PASS
img-22.height PASS
grid-23.width PASS
grid-23.height PASS
grid-23.gridTemplateColumns PASS
grid-23.gridTemplateRows PASS
img-23.width PASS
img-23.height PASS
grid-24.width PASS
grid-24.height PASS
grid-24.gridTemplateColumns PASS
grid-24.gridTemplateRows PASS
img-24.width PASS
img-24.height PASS

@ghost
Copy link

ghost commented May 24, 2017 •
edited by ghost
Loading

View the complete job log.

Sauce (MicrosoftEdge)

Testing web-platform-tests at revision c1ca5ae
Using browser at version 14.14393
Starting 10 test iterations
All results were stable

All results

1 test ran
/css/css-grid-1/grid-items/grid-minimum-size-grid-items-021.html
Subtest Results Messages
OK
grid-1.width FAIL assert_equals: expected "200px" but got "996px"
grid-1.height FAIL assert_equals: expected "200px" but got "204.05px"
grid-1.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-1.gridTemplateRows FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
img-1.width PASS
img-1.height PASS
grid-2.width PASS
grid-2.height PASS
grid-2.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-2.gridTemplateRows FAIL assert_equals: expected (string) "50px" but got (undefined) undefined
img-2.width PASS
img-2.height PASS
grid-3.width PASS
grid-3.height FAIL assert_equals: expected "50px" but got "204.05px"
grid-3.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-3.gridTemplateRows FAIL assert_equals: expected (string) "50px" but got (undefined) undefined
img-3.width PASS
img-3.height PASS
grid-4.width PASS
grid-4.height PASS
grid-4.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-4.gridTemplateRows FAIL assert_equals: expected (string) "50px" but got (undefined) undefined
img-4.width PASS
img-4.height PASS
grid-5.width PASS
grid-5.height FAIL assert_equals: expected "50px" but got "204.05px"
grid-5.gridTemplateColumns FAIL assert_equals: expected (string) "50px" but got (undefined) undefined
grid-5.gridTemplateRows FAIL assert_equals: expected (string) "50px" but got (undefined) undefined
img-5.width FAIL assert_equals: expected "50px" but got "200px"
img-5.height FAIL assert_equals: expected "50px" but got "200px"
grid-6.width PASS
grid-6.height PASS
grid-6.gridTemplateColumns FAIL assert_equals: expected (string) "50px" but got (undefined) undefined
grid-6.gridTemplateRows FAIL assert_equals: expected (string) "50px" but got (undefined) undefined
img-6.width FAIL assert_equals: expected "50px" but got "200px"
img-6.height FAIL assert_equals: expected "50px" but got "200px"
grid-7.width FAIL assert_equals: expected "200px" but got "996px"
grid-7.height FAIL assert_equals: expected "225px" but got "229.05px"
grid-7.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-7.gridTemplateRows FAIL assert_equals: expected (string) "200px 25px" but got (undefined) undefined
img-7.width PASS
img-7.height PASS
grid-8.width PASS
grid-8.height PASS
grid-8.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-8.gridTemplateRows FAIL assert_equals: expected (string) "50px 25px" but got (undefined) undefined
img-8.width PASS
img-8.height PASS
grid-9.width PASS
grid-9.height FAIL assert_equals: expected "125px" but got "229.05px"
grid-9.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-9.gridTemplateRows FAIL assert_equals: expected (string) "100px 25px" but got (undefined) undefined
img-9.width PASS
img-9.height PASS
grid-10.width PASS
grid-10.height PASS
grid-10.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-10.gridTemplateRows FAIL assert_equals: expected (string) "50px 25px" but got (undefined) undefined
img-10.width PASS
img-10.height PASS
grid-11.width PASS
grid-11.height FAIL assert_equals: expected "125px" but got "229.05px"
grid-11.gridTemplateColumns FAIL assert_equals: expected (string) "100px" but got (undefined) undefined
grid-11.gridTemplateRows FAIL assert_equals: expected (string) "100px 25px" but got (undefined) undefined
img-11.width FAIL assert_equals: expected "100px" but got "200px"
img-11.height FAIL assert_equals: expected "100px" but got "200px"
grid-12.width PASS
grid-12.height PASS
grid-12.gridTemplateColumns FAIL assert_equals: expected (string) "100px" but got (undefined) undefined
grid-12.gridTemplateRows FAIL assert_equals: expected (string) "50px 25px" but got (undefined) undefined
img-12.width FAIL assert_equals: expected "100px" but got "200px"
img-12.height FAIL assert_equals: expected "100px" but got "200px"
grid-13.width FAIL assert_equals: expected "200px" but got "996px"
grid-13.height FAIL assert_equals: expected "200px" but got "204.05px"
grid-13.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-13.gridTemplateRows FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
img-13.width PASS
img-13.height PASS
grid-14.width PASS
grid-14.height PASS
grid-14.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-14.gridTemplateRows FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
img-14.width PASS
img-14.height PASS
grid-15.width PASS
grid-15.height FAIL assert_equals: expected "200px" but got "204.05px"
grid-15.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-15.gridTemplateRows FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
img-15.width PASS
img-15.height PASS
grid-16.width PASS
grid-16.height PASS
grid-16.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-16.gridTemplateRows FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
img-16.width PASS
img-16.height PASS
grid-17.width PASS
grid-17.height FAIL assert_equals: expected "200px" but got "204.05px"
grid-17.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-17.gridTemplateRows FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
img-17.width PASS
img-17.height PASS
grid-18.width PASS
grid-18.height PASS
grid-18.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-18.gridTemplateRows FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
img-18.width PASS
img-18.height PASS
grid-19.width FAIL assert_equals: expected "200px" but got "996px"
grid-19.height FAIL assert_equals: expected "225px" but got "229.05px"
grid-19.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-19.gridTemplateRows FAIL assert_equals: expected (string) "200px 25px" but got (undefined) undefined
img-19.width PASS
img-19.height PASS
grid-20.width PASS
grid-20.height PASS
grid-20.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-20.gridTemplateRows FAIL assert_equals: expected (string) "200px 25px" but got (undefined) undefined
img-20.width PASS
img-20.height PASS
grid-21.width PASS
grid-21.height FAIL assert_equals: expected "225px" but got "229.05px"
grid-21.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-21.gridTemplateRows FAIL assert_equals: expected (string) "200px 25px" but got (undefined) undefined
img-21.width PASS
img-21.height PASS
grid-22.width PASS
grid-22.height PASS
grid-22.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-22.gridTemplateRows FAIL assert_equals: expected (string) "200px 25px" but got (undefined) undefined
img-22.width PASS
img-22.height PASS
grid-23.width PASS
grid-23.height FAIL assert_equals: expected "225px" but got "229.05px"
grid-23.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-23.gridTemplateRows FAIL assert_equals: expected (string) "200px 25px" but got (undefined) undefined
img-23.width PASS
img-23.height PASS
grid-24.width PASS
grid-24.height PASS
grid-24.gridTemplateColumns FAIL assert_equals: expected (string) "200px" but got (undefined) undefined
grid-24.gridTemplateRows FAIL assert_equals: expected (string) "200px 25px" but got (undefined) undefined
img-24.width PASS
img-24.height PASS

@mrego
Copy link
Member Author

mrego commented May 24, 2017

@mrego: I understood that the current spec text is going to be changed, why do you say the current text is correct?

I meant that this test is currently right, until the spec is not modified. That should happen soon, but we never know when it's going to happen exactly. So I was wondering if it'd make sense to merge this first and later update it once the spec is modified. Waiting for the spec to be revised works for me too.

And almost 2 months have passe and the spec has not been updated yet.
I still believe it'd be nice to land this to have coverage in Chromium and WebKit, once the spec is modified we would just need to update it accordingly.
@svillar WDYT?

@svillar
Copy link
Contributor

svillar commented May 25, 2017

OK. Let's go ahead, but we should keep an eye on it.

mrego added 2 commits May 25, 2017 10:31
@mrego
[css-grid] Add test to verify the minimum size of images
007814e 
This is a test created from issue w3c/csswg-drafts#1117.
The test checks how the automatic minimum size of images affect
to the grid container sizing and the track sizes.
The test also verifies the size of the image in the different cases.

The test combines the following cases:
* A grid container with fixed width (smaller and bigger than the image).
* A constrained grid container.
* A grid container without default "justify-content: stretch".
* A grid container with an extra test item.
* An image with a fixed width (smaller and bigger than the image original size).
* An image with a percentage width.
@mrego
[css-grid] Fix test to wait for images to be loaded before running it
a54be81 
grid-items/grid-minimum-size-grid-items-021.html was flacky
on the different browsers as sometimes they run the checks
before the images were loaded.
This patch fixes this issue waiting for the "load" event
before running them.
@mrego mrego force-pushed the css-grid-test-minimum-size-image branch from 91ab32a to a54be81 Compare May 25, 2017 08:31
@wpt-pr-bot wpt-pr-bot requested a review from svillar May 25, 2017 08:31
@mrego mrego merged commit 00541f3 into web-platform-tests:master May 25, 2017
@mrego
Copy link
Member Author

mrego commented May 25, 2017

Thanks for the review @svillar, and thanks for the approval @jgraham hopefully we won't need to bother you in the future. 😄

@mrego mrego deleted the css-grid-test-minimum-size-image branch May 25, 2017 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svillar svillar svillar approved these changes

@jgraham jgraham jgraham approved these changes

@tomalec tomalec Awaiting requested review from tomalec

@gsnedders gsnedders Awaiting requested review from gsnedders

@tabatkins tabatkins Awaiting requested review from tabatkins

@fantasai fantasai Awaiting requested review from fantasai

@jxs jxs Awaiting requested review from jxs

@plinss plinss Awaiting requested review from plinss

@atanassov atanassov Awaiting requested review from atanassov

@javifernandez javifernandez Awaiting requested review from javifernandez

Assignees
No one assigned
Labels
css-grid wg-css
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mrego @wpt-pr-bot @svillar @gsnedders @jgraham