WebCryptoAPI: Check that generated JWK public and private keys match #53680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating extractable key pairs, check that the exported JWK public key is a superset of the exported JWK private key (with the exception of the `key_ops` property).
Collaborator
|
There are no reviewers for this pull request besides its author. Please reach out on the chat room to get help with this. Thank you! |
panva
approved these changes
Jul 20, 2025
annevk
approved these changes
Jul 21, 2025
| ]); | ||
|
|
||
| if (extractable) { | ||
| // Test that the JWK public key is a superset of the JWK private key. |
Member
There was a problem hiding this comment.
This is true for all JWK key types then?
Member
Author
There was a problem hiding this comment.
Yeah, at least for all algorithms in Web Crypto, the JWK export steps only have additional steps for private keys, not for public keys.
foolip
pushed a commit
that referenced
this pull request
Aug 13, 2025
…53680) When generating extractable key pairs, check that the exported JWK public key is a superset of the exported JWK private key (with the exception of the `key_ops` property).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating extractable key pairs, check that the exported JWK public key is a superset of the exported JWK private key (with the exception of the
key_opsproperty).This test fails for X25519 in WebKitGTK 2.49.3 in Epiphany Technology Preview 49.alpha.1-33-g785305607+.