[ES6 modules] Add WPT for loading cyclic module graph w/ slow imports #6228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 14, 2017
Firefox (nightly)Testing web-platform-tests at revision 60c65a4 All results1 test ran/html/semantics/scripting-1/the-script-element/module/slow-cycle.html
|
Sauce (safari)Testing web-platform-tests at revision 60c65a4 All results1 test ran/html/semantics/scripting-1/the-script-element/module/slow-cycle.html
|
Chrome (unstable)Testing web-platform-tests at revision 60c65a4 |
Sauce (MicrosoftEdge)Testing web-platform-tests at revision 60c65a4 All results1 test ran/html/semantics/scripting-1/the-script-element/module/slow-cycle.html
|
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-I3cf8a640a73083ad612c96fc4bbd0f01e00f6e46
branch
from
7ea69af
to
fe52756
Compare
This CL adds a layout test demonstrating the currently broken cycle handling, which currently fails on ToT. If a cyclic module graph node contained other edges that are not part of the cycle, the graph does not load reliably. (To be more specific, the graph does not load unless the other edges complete loading before we instantiate the cycle nodes). We expect to have the root cause fixed in the spec change PR: whatwg/html#2674 Bug: 594639 Change-Id: I3cf8a640a73083ad612c96fc4bbd0f01e00f6e46 Reviewed-on: https://chromium-review.googlesource.com/535413 Cr-Commit-Position: refs/heads/master@{#479534} WPT-Export-Revision: 1d8720afaeeb738690321b52bc88960ecb3b36f3
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-I3cf8a640a73083ad612c96fc4bbd0f01e00f6e46
branch
from
fe52756
to
996343f
Compare
chromium-wpt-export-bot
deleted the
chromium-export-cl-I3cf8a640a73083ad612c96fc4bbd0f01e00f6e46
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ES6 modules] Add WPT for loading cyclic module graph w/ slow imports
This CL adds a layout test demonstrating the currently broken cycle handling,
which currently fails on ToT.
If a cyclic module graph node contained other edges that are not part
of the cycle, the graph does not load reliably. (To be more specific,
the graph does not load unless the other edges complete loading before
we instantiate the cycle nodes).
We expect to have the root cause fixed in the spec change PR:
whatwg/html#2674
Bug: 594639
Change-Id: I3cf8a640a73083ad612c96fc4bbd0f01e00f6e46
Reviewed-on: https://chromium-review.googlesource.com/535413
Cr-Commit-Position: refs/heads/master@{#479534}
WPT-Export-Revision: 1d8720afaeeb738690321b52bc88960ecb3b36f3