-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change webhook URL and add functionality for each job to post to bot #6719
Conversation
Reviewed 3 of 3 files at r1. .travis.yml, line 100 at r1 (raw file):
Noting that this is a thing that needs to be changed, so we have all data in Reviewable check_stability.ini, line 10 at r1 (raw file):
Noting that this is a thing that needs to be changed, so we have all data in Reviewable Comments from Reviewable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I defer to @jgraham pending resolution of his review comments
Build PASSEDStarted: 2017-08-09 11:42:30 View more information about this build on: |
Almost there. Looks like I need to fix a conditional in the template. |
f571a01
to
7eb932f
Compare
@jgraham I think this is ready to go pending the following:
I'll do #3 after 1 and 2 because doing that will cause it to start immediately posting to the production server. You can see it populating http://pulls-staging.web-platform-tests.org/ with pulls (but no build data except for this PR) already. The other open question is SSL. I don't think it should hold us up since there's nothing protected there. I'm working with the infrastructure people on our side to make getting and renewing that certificate free and painless for all, but probably won't have that until next week. |
@jgraham. I've added web-platform-tests/pulls.web-platform-tests.org#12 for SSL support to the dashboard. Do you have any other review on this PR before I switch it to reference the production servers instead of staging? |
7eb932f
to
6d056b9
Compare
Review status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful. .travis.yml, line 100 at r1 (raw file): Previously, jgraham wrote…
Done. check_stability.ini, line 10 at r1 (raw file): Previously, jgraham wrote…
Done. Comments from Reviewable |
6d056b9
to
951985b
Compare
Reviewed 2 of 2 files at r2. Comments from Reviewable |
This is the PR that will switch from using prbuildbot to the wptdash app. This is dependent on @sideshowbarker completing the GitHub Token setup and updating the vault file in wptdash, but I wanted to get this in front of @jgraham as it includes new check_stability code.
This currently points to the staging server so we can make sure it works before landing. Need to change that before merging.
This change is