Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Must throw on duplicate shippingOptions ids #7217

Merged
merged 2 commits into from
Sep 4, 2017

Conversation

marcoscaceres
Copy link
Contributor

@marcoscaceres marcoscaceres commented Sep 1, 2017

@ghost
Copy link

ghost commented Sep 1, 2017

Build PASSED

Started: 2017-09-01 05:04:34
Finished: 2017-09-01 05:07:45

View more information about this build on:

Copy link
Contributor

@edenchuang edenchuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcoscaceres marcoscaceres merged commit 236959b into master Sep 4, 2017
@marcoscaceres marcoscaceres deleted the marcoscaceres-patch-4 branch September 4, 2017 06:01
rachelandrew pushed a commit to rachelandrew/web-platform-tests that referenced this pull request Nov 8, 2017
jakearchibald pushed a commit to jakearchibald/web-platform-tests that referenced this pull request Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants