URL: test port parsing when integer overflow can occur #7602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests folowing numbers as port: 2^32 + 81 = 4294967377 2^64 + 81 = 18446744073709551697 2^128 + 81 = 340282366920938463463374607431768211537 If an integer overflow checking is implemented incorrectly then the port may be parsed to 81. But an implementation must return failure.
annevk
approved these changes
Oct 6, 2017
Build PASSEDStarted: 2017-10-06 09:42:59
Failing Jobs
Unstable BrowsersBrowser: "Microsoftedge 14.14393" (failures allowed)View in: WPT PR Status | TravisCI |
rmisev
added a commit
to rmisev/node
that referenced
this pull request
Oct 6, 2017
3 tasks
TimothyGu
pushed a commit
to nodejs/node
that referenced
this pull request
Oct 10, 2017
This patch adds (port > 0xffff) check after each digit in the loop and prevents integer overflow. PR-URL: #15794 Refs: web-platform-tests/wpt#7602 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
This patch adds (port > 0xffff) check after each digit in the loop and prevents integer overflow. PR-URL: nodejs/node#15794 Refs: web-platform-tests/wpt#7602 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos
pushed a commit
to nodejs/node
that referenced
this pull request
Oct 18, 2017
This patch adds (port > 0xffff) check after each digit in the loop and prevents integer overflow. PR-URL: #15794 Refs: web-platform-tests/wpt#7602 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests folowing numbers as port:
232 + 81 = 4294967377
264 + 81 = 18446744073709551697
2128 + 81 = 340282366920938463463374607431768211537
If an integer overflow checking is implemented incorrectly then the port may be parsed to
81. But an implementation must return failure.Related bug fix: nodejs/node#15794