Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More dynamic import() string compilation tests #7684

Merged
merged 1 commit into from
Dec 18, 2017
Merged

Conversation

domenic
Copy link
Member

@domenic domenic commented Oct 11, 2017

More dynamic import() string compilation tests

Follows whatwg/html#3117. Parser state is implicitly tested because lots of tests would otherwise fail.

Referrer policy tests omitted for now since you can only set that via modulepreload at the moment.

@domenic
Copy link
Member Author

domenic commented Oct 11, 2017

The nonce ones may change slightly depending on how we go with whatwg/html#3116, but I think we should merge them for now, probably? Updated

@ghost
Copy link

ghost commented Oct 11, 2017

Build PASSED

Started: 2017-12-15 22:52:56
Finished: 2017-12-15 23:18:18

Failing Jobs

  • MicrosoftEdge:14.14393

View more information about this build on:

Follows whatwg/html#3117. Parser state is implicitly tested because lots of tests would otherwise fail.

Referrer policy tests omitted for now since you can only set that via modulepreload at the moment.
@domenic domenic force-pushed the more-import-tests-2 branch from 69bd70b to e811047 Compare December 15, 2017 22:52
@domenic domenic changed the title More dynamic import() string compilation tests: base URLs and nonces More dynamic import() string compilation tests Dec 15, 2017
@nyaxt
Copy link
Member

nyaxt commented Dec 18, 2017

lgtm

@annevk annevk merged commit 4051dc7 into master Dec 18, 2017
@annevk annevk deleted the more-import-tests-2 branch December 18, 2017 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants