Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WPT tests for feature policy frame policy #8922

Merged
merged 1 commit into from
Mar 14, 2018

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jan 4, 2018

  1. Without specifying allow attribute, frame policy inherits correctly.
  2. With allow attribute, frame policy inherits from and overrides header policy
    correctly. Updating allowfullscreen and allowpaymentrequest correctly updates
    frame policy.
  3. Frame policy is not affected by the frame's document policy.

Bug: 732003
Change-Id: Ib41f883a779f11c564c91cfc03ff1224330108f5
Reviewed-on: https://chromium-review.googlesource.com/850896
Commit-Queue: Luna Lu loonybear@chromium.org
Reviewed-by: Ian Clelland iclelland@chromium.org
Cr-Commit-Position: refs/heads/master@{#542837}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@w3c-bots
Copy link

w3c-bots commented Jan 4, 2018

Build PASSED

Started: 2018-01-04 21:15:11
Finished: 2018-01-04 21:58:26

Failing Jobs

  • MicrosoftEdge:14.14393

View more information about this build on:

@w3c-bots
Copy link

w3c-bots commented Jan 25, 2018

Build ERRORED

Started: 2018-03-13 17:58:16
Finished: 2018-03-13 18:49:30

Failing Jobs

  • firefox:nightly

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-850896 branch 2 times, most recently from f5eda07 to 2758922 Compare February 27, 2018 22:53
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-850896 branch 4 times, most recently from ebed1c6 to c75f927 Compare March 13, 2018 16:50
1. Without specifying allow attribute, frame policy inherits correctly.
2. With allow attribute, frame policy inherits from and overrides header policy
   correctly. Updating allowfullscreen and allowpaymentrequest correctly updates
   frame policy.
3. Frame policy is not affected by the frame's document policy.

Bug: 732003
Change-Id: Ib41f883a779f11c564c91cfc03ff1224330108f5
Reviewed-on: https://chromium-review.googlesource.com/850896
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542837}
@foolip
Copy link
Member

foolip commented Mar 14, 2018

The Firefox job timed out. AFAICT, the number of affected tests is too large and it didn't get very far, so another case of #7660. I've also filed #10028 about the difficulty of figuring out how far we even got in the testing.

Will override the checks and merge this now.

@foolip foolip merged commit 0d817ea into master Mar 14, 2018
@foolip foolip deleted the chromium-export-cl-850896 branch March 14, 2018 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants