Switch external_host to host_ip. #9258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build PASSEDStarted: 2018-02-22 15:19:17 View more information about this build on: |
|
@jgraham can you rebase? |
When running tests in Firefox we don't require that the hostname is actually resolvable since we set up some internal DNS overrides. This means that we don't actually need to have web-platform.test defined in /etc/hosts. As a consequence when we check the server is responding, the check will typically fail for Firefox developers if we try to access by hostname. Previously we made use of a special dance in which external_host held the ip at the point of the check and was later replaced by host to actually run tests. But that changed, and instead we relied on the fact that we (accidentially) didn't actually fail in the case the servers couldn't be reached by host name. However in some cases things still failed because local DNS resolved web-patform.test to some ip address, causing hangs or other badness. In this patch we simply add a host_ip property to the config, and connect to that to test the servers are repopnsing rather than the hostname. We also actually fil if we didn't manage to connect to all the servers.
|
Hmm, I'm still not entirely happy with "host" and "host_ip"; I think that's still confusing for the same reason as "external_host" is confusing. (Ultimately, a lot of this could be solved by actually documenting our config file!). To me, "server_host" in place of "external_host" and "browser_host" in place of "host" would be clearest, though as per on IRC you disagree. |
|
Let's deal with another raound of renaming in a followup, since this fixes the original problem @bzbarsky was experiencing. |
gsnedders
approved these changes
Feb 23, 2018
jgraham
added a commit
that referenced
this pull request
Feb 23, 2018
When running tests in Firefox we don't require that the hostname is actually resolvable since we set up some internal DNS overrides. This means that we don't actually need to have web-platform.test defined in /etc/hosts. As a consequence when we check the server is responding, the check will typically fail for Firefox developers if we try to access by hostname. Previously we made use of a special dance in which external_host held the ip at the point of the check and was later replaced by host to actually run tests. But that changed, and instead we relied on the fact that we (accidentially) didn't actually fail in the case the servers couldn't be reached by host name. However in some cases things still failed because local DNS resolved web-patform.test to some ip address, causing hangs or other badness. In this patch we simply add a host_ip property to the config, and connect to that to test the servers are repopnsing rather than the hostname. We also actually fil if we didn't manage to connect to all the servers.
jgraham
added a commit
that referenced
this pull request
Mar 2, 2018
When running tests in Firefox we don't require that the hostname is actually resolvable since we set up some internal DNS overrides. This means that we don't actually need to have web-platform.test defined in /etc/hosts. As a consequence when we check the server is responding, the check will typically fail for Firefox developers if we try to access by hostname. Previously we made use of a special dance in which external_host held the ip at the point of the check and was later replaced by host to actually run tests. But that changed, and instead we relied on the fact that we (accidentially) didn't actually fail in the case the servers couldn't be reached by host name. However in some cases things still failed because local DNS resolved web-patform.test to some ip address, causing hangs or other badness. In this patch we simply add a host_ip property to the config, and connect to that to test the servers are repopnsing rather than the hostname. We also actually fil if we didn't manage to connect to all the servers.
gsnedders
pushed a commit
that referenced
this pull request
Mar 2, 2018
When running tests in Firefox we don't require that the hostname is actually resolvable since we set up some internal DNS overrides. This means that we don't actually need to have web-platform.test defined in /etc/hosts. As a consequence when we check the server is responding, the check will typically fail for Firefox developers if we try to access by hostname. Previously we made use of a special dance in which external_host held the ip at the point of the check and was later replaced by host to actually run tests. But that changed, and instead we relied on the fact that we (accidentially) didn't actually fail in the case the servers couldn't be reached by host name. However in some cases things still failed because local DNS resolved web-patform.test to some ip address, causing hangs or other badness. In this patch we simply add a host_ip property to the config, and connect to that to test the servers are repopnsing rather than the hostname. We also actually fil if we didn't manage to connect to all the servers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running tests in Firefox we don't require that the hostname is
actually resolvable since we set up some internal DNS overrides. This
means that we don't actually need to have web-platform.test defined in
/etc/hosts. As a consequence when we check the server is responding,
the check will typically fail for Firefox developers if we try to
access by hostname. Previously we made use of a special dance in which
external_host held the ip at the point of the check and was later
replaced by host to actually run tests. But that changed, and instead
we relied on the fact that we (accidentially) didn't actually fail in
the case the servers couldn't be reached by host name. However in some
cases things still failed because local DNS resolved web-patform.test
to some ip address, causing hangs or other badness.
In this patch we simply add a host_ip property to the config, and
connect to that to test the servers are repopnsing rather than the
hostname. We also actually fil if we didn't manage to connect to all
the servers.
This change is