Add tests for customElements.upgrade() #9869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
alsemenov,
deepak-sa,
dominiccooney,
hayatoito,
kojiishi,
rniwa,
sgrekhov,
snuggs and
TakayoshiKochi
Build PASSEDStarted: 2018-03-07 03:09:27 View more information about this build on: |
29 tasks
|
Hi, I think the last test here about upgrading elements inside a template's |
|
I don't see anything in the spec about browsing contexts... |
|
Oh, I didn't click through to your explanation. Sorry, re-parsing... you're probably right... Edit: confirmed. I will fix the test. Thank you! |
|
Ok, thanks for confirming! |
domenic
added a commit
that referenced
this pull request
Apr 2, 2018
tkent-google
pushed a commit
that referenced
this pull request
Apr 3, 2018
* Fix customElements.upgrade() tests for <template> See #9869 (comment). * Actually fix things
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 15, 2018
…template>, a=testonly Automatic update from web-platform-testsFix customElements.upgrade() tests for <template> (#10272) * Fix customElements.upgrade() tests for <template> See web-platform-tests/wpt#9869 (comment). * Actually fix things wpt-commits: 5b68d219206139c0bfeec65c88e765749aed57fb wpt-pr: 10272 wpt-commits: 5b68d219206139c0bfeec65c88e765749aed57fb wpt-pr: 10272
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 2, 2019
…template>, a=testonly Automatic update from web-platform-testsFix customElements.upgrade() tests for <template> (#10272) * Fix customElements.upgrade() tests for <template> See web-platform-tests/wpt#9869 (comment). * Actually fix things wpt-commits: 5b68d219206139c0bfeec65c88e765749aed57fb wpt-pr: 10272 wpt-commits: 5b68d219206139c0bfeec65c88e765749aed57fb wpt-pr: 10272 UltraBlame original commit: 8cfc4131191bfd7fc017bcaf2702396b94bb8173
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 2, 2019
…template>, a=testonly Automatic update from web-platform-testsFix customElements.upgrade() tests for <template> (#10272) * Fix customElements.upgrade() tests for <template> See web-platform-tests/wpt#9869 (comment). * Actually fix things wpt-commits: 5b68d219206139c0bfeec65c88e765749aed57fb wpt-pr: 10272 wpt-commits: 5b68d219206139c0bfeec65c88e765749aed57fb wpt-pr: 10272 UltraBlame original commit: 8cfc4131191bfd7fc017bcaf2702396b94bb8173
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 2, 2019
…template>, a=testonly Automatic update from web-platform-testsFix customElements.upgrade() tests for <template> (#10272) * Fix customElements.upgrade() tests for <template> See web-platform-tests/wpt#9869 (comment). * Actually fix things wpt-commits: 5b68d219206139c0bfeec65c88e765749aed57fb wpt-pr: 10272 wpt-commits: 5b68d219206139c0bfeec65c88e765749aed57fb wpt-pr: 10272 UltraBlame original commit: 8cfc4131191bfd7fc017bcaf2702396b94bb8173
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows whatwg/html#3535.
Ideas for more tests welcome, although testing against no implementations is a bit rough.