Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Guzzle 7 #294

Merged
merged 2 commits into from
Sep 13, 2020
Merged

Support Guzzle 7 #294

merged 2 commits into from
Sep 13, 2020

Conversation

martijnb92
Copy link
Contributor

Upgrade Guzzle version (needed for usage in Laravel 8)

Upgrade Guzzle version (needed for usage in Laravel 8)
@Spomky
Copy link
Contributor

Spomky commented Sep 11, 2020

As Guzzle is also PSR7/17 compatible, maybe it's time to rely on these interfaces instead of Guzzle directly.
This will allow developers to use Guzzle 7 or any other concrete implementation.

@Minishlink
Copy link
Member

Yes that would indeed be a great thing to do forward! Merging this for the time being

Copy link
Member

@Minishlink Minishlink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Minishlink Minishlink merged commit bbbd3e1 into web-push-libs:master Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants