Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace PHP_EOL with "\n" in certificate processing #574

Merged
merged 4 commits into from
Jun 24, 2024
Merged

Conversation

Spomky
Copy link
Member

@Spomky Spomky commented Jun 16, 2024

The PHP_EOL constant used in certificate processing has been replaced with "\n". This change impacts multiple files including KeyConverter.php, ECKey.php, and X5UFactory.php. The commit ensures consistent use of line breaks across various operating systems.

Target branch: 3.4.x
Resolves issue #568

  • It is a Bug fix
  • It is a New feature
  • It is related to dependencies

Includes:

  • Breaks BC
  • Deprecations

The PHP_EOL constant used in certificate processing has been replaced with "\n". This change impacts multiple files including KeyConverter.php, ECKey.php, and X5UFactory.php. The commit ensures consistent use of line breaks across various operating systems.
@Spomky Spomky added the bug label Jun 16, 2024
@Spomky Spomky added this to the 3.4.4 milestone Jun 16, 2024
@Spomky Spomky self-assigned this Jun 16, 2024
@Spomky Spomky linked an issue Jun 16, 2024 that may be closed by this pull request
The PHP_EOL constant used in certificate processing has been replaced with "\n". This change impacts multiple files including KeyConverter.php, ECKey.php, and X5UFactory.php. The commit ensures consistent use of line breaks across various operating systems.
@Spomky
Copy link
Member Author

Spomky commented Jun 16, 2024

Waiting for symfony/symfony#57273 to be merged up to SF6.4

The PHP_EOL constant used in certificate processing has been replaced with "\n". This change impacts multiple files including KeyConverter.php, ECKey.php, and X5UFactory.php. The commit ensures consistent use of line breaks across various operating systems.
The PHP_EOL constant used in certificate processing has been replaced with "\n". This change impacts multiple files including KeyConverter.php, ECKey.php, and X5UFactory.php. The commit ensures consistent use of line breaks across various operating systems.
@Spomky Spomky merged commit 4a05eb0 into 3.4.x Jun 24, 2024
12 of 13 checks passed
@Spomky Spomky deleted the bugs/wrong-eol branch June 24, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Newlines random based on environment
1 participant