Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content elements inside already translated b13/container containers are not shown in Localizations Modal Wizard #55

Closed
achimfritz opened this issue Apr 19, 2022 · 5 comments · Fixed by #56
Labels
bug Something isn't working

Comments

@achimfritz
Copy link

Hi,

having a already translated container and create a new CE in the default-language container

image

now try to translate ends in an 400 server error (and a frozen modal) during localization wizard (because the CE inside the container "is not found":

image
image

this is due the Xclass of EXT:container is overriden in EXT:wv_deepltranslate
correct behaviour (like in the xclass of the EXT:container)
image

i will provide a pr

s. also:
#44
b13/container#188

Tested with TYPO3 10.4.26, EXT:container 1.5, EXT:wv_deepltranslate 2.0.1

@webworker-united
Copy link

I noticed that there is another problem associated with this reported bug:

When changing the translation mode to " Free mode" in the Site Configuration, the translated content is still displayed in the default language.

This applies to all content in a container from the Ext "container".

@webworker-united
Copy link

I use TYPO3 core 11.5.10, wv_deepltranslate 2.0.1 and container 1.6.0

@dmitryd
Copy link

dmitryd commented Jun 8, 2022

Unfortunately the fix did not work me.

The problem is that wv_deepltranslate uses cmdmap incorrectly: its keys must be table names and the ext passes settings there ($cmdmap['localization']['custom']['mode']). Container extension calls DataHandler::process_cmdmap() for tt_content compltely ignoring everything else in cmdmap (as it should). So wv_deepltranslate simply does not see that it is being called for container children.

There should be a better detection of the custom translation mode.

@dmitryd
Copy link

dmitryd commented Jun 9, 2022

I'll work on a fix for my client but it will be for version 1.1.4.

dmitryd added a commit to dmitryd/wv_deepltranslate that referenced this issue Jun 9, 2022
dmitryd added a commit to dmitryd/wv_deepltranslate that referenced this issue Jun 9, 2022
@dmitryd
Copy link

dmitryd commented Jun 9, 2022

Okay. I built on top of previous PR and target master in mine. Now container children can be localized together with the parent container (just like gridelements did).

@NarkNiro NarkNiro added the bug Something isn't working label Jul 7, 2022
achimfritz pushed a commit to b13/wv_deepltranslate that referenced this issue Aug 18, 2022
@Riiiad Riiiad closed this as completed in #56 Sep 6, 2022
Riiiad pushed a commit that referenced this issue Sep 6, 2022
Riiiad pushed a commit that referenced this issue Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants