[TASK] Make glossary sync more tolerant of outdated IDs #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the method deleteGlossary is called both in backend and CLI context, the Exception should be thrown in CLI context, but generate a FlashMessage in backend context.
calien666
force-pushed
the
feature/delete-warning
branch
from
909fece
to
f125a0d
Compare
calien666
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one glossary UUID is outdated for any reason, the complete sync fails with an exception.
This PR replaces catches the exception and adds a flash message instead. So the further processing still will happen and the new glossary (or even multiple glossaries) can be updated/recreated correctly.