[FEATURE] Rework and centralize api client operation #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `DEEPLMOCKAPISERVER` is only a really rudimentary api implementation and do not simulate "full" api in any way. That means, that not all source/target languages are supported like for production api. Therefore, one test is skipped now when `DEEPLMOCKAPISERVER` is in use because of not supporting `EN` as target language. An additionally test is added to test from `EN` to `DE` in anny case. Furthermore, when mock server is used the supported content and and translated strings are used for test expectations.
The `DEEPLMOCKAPISERVER` is only a really rudimentary api implementation and do not simulate "full" api in any way. That means, that not all source/target languages are supported like for production api. Therefore, when mock server is used, the supported content and and translated strings are used for test expectations.
The `DEEPLMOCKAPISERVER` is only a really rudimentary api implementation and do not simulate "full" api in any way. That means, that not all source/target languages are supported like for production api. Therefore, when mock server is used, the supported content and and translated strings are used for test expectations. [TASK] Donate fine grained method to retrieve api url parts `\WebVision\WvDeepltranslate\Configuration` transports the required configuration settings through the system, which is a good approach. This change donates more fine grained read methods to this class, to access api url parts. This is a preparation for an upcoming change.
In a couple of places, `https` has been hardcoded enforced as request scheme, ignoring the scheme of the configured api url. This may seem to be a "security" enforcement, but these kind of overrides are not very user friendly and hidden magic is always a pain in the ass for debugging issues. This change now re-uses the configured api url scheme when building api requests. One test is adopted to do the same. The donated methods on the `Configuration` class to access api url parts are used for this.
calien666
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #188