[BUGFIX] Fix google translation error "Bad language pair" #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoogleTranslateService::translate() expects the source language as web-vision#1 parameter and the target language as web-vision#2 parameter. So far, the target language was passed in both cases. This led to the error "Bad language pair". This fix sets the source language as web-vision#1 parameter instead.
calien666
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GoogleTranslateService::translate() expects the source language as first parameter and the target language as second parameter. So far, the target language was passed in both cases. This led to the error "Bad language pair". This fix sets the source language as first parameter instead.