Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with upstream fork #2

Closed
wants to merge 7 commits into from

Conversation

cgewecke
Copy link

@cgewecke cgewecke commented May 21, 2020

This should resolve web3 3371 and silence node-gyp error output that alarms Windows users.

There's no CI here but am seeing tests pass locally:

Screen Shot 2020-05-21 at 5 01 30 PM

theturtle32 and others added 7 commits September 12, 2019 11:10
…tron engines) (theturtle32#376)

* adding compatibility with V8 release greater than v7.6
* using the Maybe types to solve the deprecation warning
…heturtle32#362)

The [es5-ext/global][es5g] module is based on Mathias Bynens' [polyfill][poly]
for [`globalThis`][gT]. It uses the same robust technique but is more
conservative in that it does not add a `globalThis` property to the resolved
object, i.e. `window` in a browser and `global` in Node. It also lacks the "old
IE" fallback seen in a [demo][demo] of the original polyfill, but that is
easily provided in this commit.

[es5g]: https://github.com/medikoo/es5-ext/blob/master/global.js
[poly]: https://mathiasbynens.be/notes/globalthis
[gT]: https://github.com/tc39/proposal-global
[demo]: https://mathiasbynens.be/demo/globalthis-ie
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update websocket fork (node-gyp err output on Windows / Node 12)
7 participants