Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workaround for ts bug in upload capabilities #171

Merged
merged 2 commits into from
Nov 16, 2022

Conversation

vasco-santos
Copy link
Contributor

Same as #169 but for upload capabilities. Did also a quick look at generated types in other capabilities and they look fine.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 16, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e74e75f
Status: ✅  Deploy successful!
Preview URL: https://3268bba9.ucan-protocol.pages.dev
Branch Preview URL: https://fix-workaround-for-ts-bug-in.ucan-protocol.pages.dev

View logs

@vasco-santos
Copy link
Contributor Author

Before fix

image

After fix

image

@vasco-santos vasco-santos marked this pull request as ready for review November 16, 2022 15:47
@vasco-santos vasco-santos requested review from Gozala and alanshaw and removed request for Gozala November 16, 2022 15:47
packages/access/src/capabilities/upload.js Outdated Show resolved Hide resolved
Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
@vasco-santos vasco-santos merged commit b8d05b2 into main Nov 16, 2022
@vasco-santos vasco-santos deleted the fix/workaround-for-ts-bug-in-upload-capabilities branch November 16, 2022 16:49
vasco-santos pushed a commit that referenced this pull request Nov 16, 2022
🤖 I have created a release *beep* *boop*
---


##
[5.0.2](access-v5.0.1...access-v5.0.2)
(2022-11-16)


### Bug Fixes

* workaround for ts bug in upload capabilities
([#171](#171))
([b8d05b2](b8d05b2))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
gobengo pushed a commit that referenced this pull request Apr 11, 2023
Same as #169 but for
upload capabilities. Did also a quick look at generated types in other
capabilities and they look fine.

Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
gobengo pushed a commit that referenced this pull request Apr 11, 2023
🤖 I have created a release *beep* *boop*
---


##
[5.0.2](access-v5.0.1...access-v5.0.2)
(2022-11-16)


### Bug Fixes

* workaround for ts bug in upload capabilities
([#171](#171))
([37bbe28](37bbe28))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants