feat: get access/claim authorization wait function working
#666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build on @Bengo's `access/claim`-polling-based `waitForDelegationOnSocket` replacement. This will let us replace the websocket-based authorization wait function which makes the UX much more responsive - rather than waiting an indeterminate amount of time after clicking the email link, the process completes almost immediately with this change. The wait function is also pluggable so we that clients can implement different polling strategies, which should make it easier to test and use a receipt-based version of this in the future.
authorizeWaitAndClaim defaults to using the new `access/claim` polling based auth flow and and should react to email clicks much more quickly
gobengo
reviewed
Mar 28, 2023
gobengo
reviewed
Mar 28, 2023
gobengo
reviewed
Mar 28, 2023
gobengo
reviewed
Mar 28, 2023
gobengo
reviewed
Mar 28, 2023
gobengo
reviewed
Mar 28, 2023
gobengo
reviewed
Mar 28, 2023
alanshaw
reviewed
Mar 29, 2023
alanshaw
approved these changes
Mar 29, 2023
per @Bengo's suggestion
plus use opts instead of options for consistency
gobengo
approved these changes
Mar 29, 2023
This was referenced Mar 29, 2023
travis
pushed a commit
that referenced
this pull request
Mar 29, 2023
🤖 I have created a release *beep* *boop* --- ## [11.1.0](access-v11.0.1...access-v11.1.0) (2023-03-29) ### Features * get `access/claim` authorization wait function working ([#666](#666)) ([83971de](83971de)) ### Bug Fixes * verify proofs exist for requested delegation capabilities ([#670](#670)) ([068e801](068e801)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
alanshaw
pushed a commit
that referenced
this pull request
Mar 29, 2023
🤖 I have created a release *beep* *boop* --- ## [5.5.0](w3up-client-v5.4.0...w3up-client-v5.5.0) (2023-03-29) ### Features * add capabilities option type for authorize ([#687](#687)) ([bf262dd](bf262dd)) * get `access/claim` authorization wait function working ([#666](#666)) ([83971de](83971de)) ### Bug Fixes * missing file from byo principal ([6b2384e](6b2384e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
gobengo
pushed a commit
that referenced
this pull request
Apr 11, 2023
Build on @Bengo's `access/claim`-polling-based `waitForDelegationOnSocket` replacement. This will let us replace the websocket-based authorization wait function which makes the UX much more responsive - rather than waiting an indeterminate amount of time after clicking the email link, the process completes almost immediately with this change. The wait function is also pluggable so we that clients can implement different polling strategies, which should make it easier to test and use a receipt-based version of this in the future. Added tests for this that use `sinon` to mock out service handlers and ensure they are called the right number of times.
gobengo
pushed a commit
that referenced
this pull request
Apr 11, 2023
🤖 I have created a release *beep* *boop* --- ## [11.1.0](access-v11.0.1...access-v11.1.0) (2023-03-29) ### Features * get `access/claim` authorization wait function working ([#666](#666)) ([1d0e208](1d0e208)) ### Bug Fixes * verify proofs exist for requested delegation capabilities ([#670](#670)) ([a0cea8f](a0cea8f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
gobengo
pushed a commit
that referenced
this pull request
Apr 11, 2023
🤖 I have created a release *beep* *boop* --- ## [5.5.0](w3up-client-v5.4.0...w3up-client-v5.5.0) (2023-03-29) ### Features * add capabilities option type for authorize ([#687](#687)) ([57697ad](57697ad)) * get `access/claim` authorization wait function working ([#666](#666)) ([1d0e208](1d0e208)) ### Bug Fixes * missing file from byo principal ([ac9b413](ac9b413)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build on @Bengo's
access/claim-polling-basedwaitForDelegationOnSocketreplacement. This will let us replace the websocket-based authorization wait function which makes the UX much more responsive - rather than waiting an indeterminate amount of time after clicking the email link, the process completes almost immediately with this change.The wait function is also pluggable so we that clients can implement different polling strategies, which should make it easier to test and use a receipt-based version of this in the future.
Added tests for this that use
sinonto mock out service handlers and ensure they are called the right number of times.