fix: make unixfs importer on ipfs-car use same defaults as lotus #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanshaw
approved these changes
Jul 26, 2021
vasco-santos
deleted the
fix/make-unix-fs-importer-defaults-same-as-lotus
branch
This was referenced Jul 26, 2021
|
@hugomrdias any idea why this PR was flagged as |
|
oh, i see, it is a breaking change 06f6948 |
vasco-santos
added a commit
to storacha/add-to-web3
that referenced
this pull request
Jan 5, 2022
BREAKING CHANGE: make unixfs importer on ipfs-car use same defaults as lotus (web3-storage/web3.storage#170)
vasco-santos
added a commit
to storacha/add-to-web3
that referenced
this pull request
Jan 5, 2022
BREAKING CHANGE: make unixfs importer on ipfs-car use same defaults as lotus (web3-storage/web3.storage#170)
vasco-santos
added a commit
to storacha/add-to-web3
that referenced
this pull request
Jan 5, 2022
BREAKING CHANGE: make unixfs importer on ipfs-car use same defaults as lotus (web3-storage/web3.storage#170)
vasco-santos
added a commit
to storacha/add-to-web3
that referenced
this pull request
Jan 5, 2022
BREAKING CHANGE: make unixfs importer on ipfs-car use same defaults as lotus (web3-storage/web3.storage#170)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
ipfs-carpacking with amaxChunkSizeof 1048576 and amaxChildrenPerNode1024.We will keep using
sha256hasher instead of @multiformats/blake2 given it is way slower (a minimal set of tests showed ~6x slower)Needs:
resolves #173