Merge pull request #3303 from ethereum/pri/contract-js-clean

Minimize changes to test/contract.js (#3190)
web3 · Jan 27, 2020 · 100dab7 · 100dab7
2 parents cd680eb + 561c3eb
commit 100dab7
Show file tree

Hide file tree

Showing 3 changed files with 700 additions and 705 deletions.
diff --git a/docs/include_package-core.rst b/docs/include_package-core.rst
@@ -13,7 +13,8 @@ setProvider
 
 Will change the provider for its module.
 
-.. note:: When called on the umbrella package ``web3`` it will also set the provider for all sub modules ``web3.eth``, ``web3.shh``, etc EXCEPT ``web3.bzz`` which needs a separate provider at all times.
+.. note::
+ When called on the umbrella package ``web3`` it will also set the provider for all sub modules ``web3.eth``, ``web3.shh``, etc EXCEPT ``web3.bzz`` which needs a separate provider at all times.
 
 ----------
 Parameters

diff --git a/packages/web3-core-requestmanager/src/index.js b/packages/web3-core-requestmanager/src/index.js
@@ -260,7 +260,7 @@ RequestManager.prototype.clearSubscriptions = function (keepIsSyncing) {
  var _this = this;
 
  // uninstall all subscriptions
- if (this.subscriptions) {
+ if (this.subscriptions.size > 0) {
  this.subscriptions.forEach(function (value, id) {
  if (!keepIsSyncing || value.name !== 'syncing')
  _this.removeSubscription(id);