Skip to content

Commit

Permalink
Merge pull request #2557 from ethereum/issue/2551
Browse files Browse the repository at this point in the history
DeployTransactionResponse renamed to ContractSendMethod
  • Loading branch information
nivida authored Mar 22, 2019
2 parents 0cb5562 + 557854a commit 22a190c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
6 changes: 2 additions & 4 deletions packages/web3-eth-contract/types/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export class Contract {

clone(): Contract;

deploy(options: DeployOptions): DeployTransactionResponse;
deploy(options: DeployOptions): ContractSendMethod;

methods: any;

Expand Down Expand Up @@ -64,9 +64,7 @@ export interface DeployOptions {
arguments?: any[];
}

export interface DeployTransactionResponse {
array: any[];

export interface ContractSendMethod {
send(options: SendOptions, callback?: (err: Error, contracts: Contract) => void): PromiEvent<Contract>;

estimateGas(options: EstimateGasOptions, callback?: (err: Error, gas: number) => void): Promise<number>;
Expand Down
2 changes: 1 addition & 1 deletion packages/web3-eth-contract/types/tests/contract-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const contract = new Contract('http://localhost:500', {type: 'constructor'});
// $ExpectType Contract
contract.clone();

// $ExpectType DeployTransactionResponse
// $ExpectType ContractSendMethod
contract.deploy({
data: '0x12345...',
arguments: [123, 'My String']
Expand Down

0 comments on commit 22a190c

Please sign in to comment.