Merge pull request #3531 from ethereum/issue/3257

Fix eth.clearSubscriptions size property de-referencing bug

CHANGELOG.md

@@ -210,3 +210,5 @@ Released with 1.0.0-beta.37 code base.
 ### Changed
 
 ### Fixed
+
+- Fix size property de-referencing crash when calling web3.eth.clearSubscriptions (#3527)

packages/web3-eth/src/index.js

@@ -265,7 +265,7 @@ var Eth = function Eth() {
     });
 
 
-    this.clearSubscriptions = _this._requestManager.clearSubscriptions;
+    this.clearSubscriptions = _this._requestManager.clearSubscriptions.bind(_this._requestManager);
 
     // add net
     this.net = new Net(this);

test/eth.subscribe.ganache.js

@@ -54,6 +54,15 @@ describe('subscription connect/reconnect', function () {
             });
     });
 
+    it('clearSubscriptions', async function() {
+        web3.eth.subscribe('newBlockHeaders');
+        await waitSeconds(1); // Sub need a little time to set up
+
+        assert.equal(1, web3.eth._requestManager.subscriptions.size);
+        web3.eth.clearSubscriptions();
+        assert.equal(0, web3.eth._requestManager.subscriptions.size);
+    });
+
     it('resubscribes to an existing subscription', function (done) {
         this.timeout(5000);