Fix parsing of non-eth_subscription provider events (#3660)

* fix parsing provider subscription by checking for result.params.subscripton, as other non-subscription events may come down the pipe * add to changelog
web3 · Jul 28, 2020 · 6cae35d · 6cae35d
1 parent bf06daa
commit 6cae35d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -279,3 +279,4 @@ Released with 1.0.0-beta.37 code base.
 
 ### Fixed
 
+- Fix parsing of non-`eth_subscription` provider events (#3660)
diff --git a/packages/web3-core-requestmanager/src/index.js b/packages/web3-core-requestmanager/src/index.js
@@ -101,8 +101,8 @@ RequestManager.prototype.setProvider = function (provider, net) {
  this.provider.on('data', function data(result, deprecatedResult) {
  result = result || deprecatedResult; // this is for possible old providers, which may had the error first handler
 
- // check for result.method, to prevent old providers errors to pass as result
- if (result.method && _this.subscriptions.has(result.params.subscription)) {
+ // if result is a subscription, call callback for that subscription
+ if (result.method && result.params && result.params.subscription && _this.subscriptions.has(result.params.subscription)) {
  _this.subscriptions.get(result.params.subscription).callback(null, result.params.result);
  }
  });