Gas check fix back-ported to 1.x (#3123)

web3 · Oct 11, 2019 · 7a51cdc · 7a51cdc
1 parent 5e8738e
commit 7a51cdc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -69,3 +69,4 @@ Released with 1.0.0-beta.37 code base.
 - Fix accessing event.name where event is undefined (#3014)
 - Fix bubbling up tx signing errors (#2063, #3105)
 - HttpProvider: CORS issue with Firefox and Safari (#2978)
+- Gas check fixed (#2381)
diff --git a/packages/web3-core-method/src/index.js b/packages/web3-core-method/src/index.js
@@ -348,7 +348,7 @@ Method.prototype._confirmTransaction = function (defer, result, payload) {
  if (!isContractDeployment && !promiseResolved) {
 
  if(!receipt.outOfGas &&
- (!gasProvided || gasProvided !== receipt.gasUsed) &&
+ (!gasProvided || gasProvided !== utils.numberToHex(receipt.gasUsed)) &&
  (receipt.status === true || receipt.status === '0x1' || typeof receipt.status === 'undefined')) {
  defer.eventEmitter.emit('receipt', receipt);
  defer.resolve(receipt);