Copy block params for historical logs request

web3 · Mar 3, 2020 · 7f3f42b · 7f3f42b
1 parent 64c1302
commit 7f3f42b
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/packages/web3-core-subscriptions/src/subscription.js b/packages/web3-core-subscriptions/src/subscription.js
@@ -232,9 +232,13 @@ Subscription.prototype.subscribe = function() {
  // get past logs, if fromBlock is available
  if(payload.params[0] === 'logs' && _.isObject(payload.params[1]) && payload.params[1].hasOwnProperty('fromBlock') && isFinite(payload.params[1].fromBlock)) {
  // send the subscription request
+
+ // copy the params to avoid race-condition with deletion below this block
+ var blockParams = Object.assign({}, payload.params[1]);
+
  this.options.requestManager.send({
  method: 'eth_getLogs',
- params: [payload.params[1]]
+ params: [blockParams]
  }, function (err, logs) {
  if(!err) {
  logs.forEach(function(log){