Merge pull request #2390 from ethereum/issue/2369

GetBlockTransactionCountMethod fixed
web3 · Feb 20, 2019 · 82819bc · 82819bc
2 parents 6698bfd + f7af2a9
commit 82819bc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/packages/web3-core-method/src/methods/block/GetBlockTransactionCountMethod.js b/packages/web3-core-method/src/methods/block/GetBlockTransactionCountMethod.js
@@ -30,7 +30,7 @@ export default class GetBlockTransactionCountMethod extends AbstractCallMethod {
  * @constructor
  */
  constructor(utils, formatters) {
- super('eth_getTransactionByBlockNumberAndIndex', 1, utils, formatters);
+ super('eth_getBlockTransactionCountByNumber', 1, utils, formatters);
  }
 
  /**
@@ -42,7 +42,7 @@ export default class GetBlockTransactionCountMethod extends AbstractCallMethod {
  */
  beforeExecution(moduleInstance) {
  if (this.isHash(this.parameters[0])) {
- this.rpcMethod = 'eth_getTransactionByBlockHashAndIndex';
+ this.rpcMethod = 'eth_getBlockTransactionCountByHash';
  }
 
  this.parameters[0] = this.formatters.inputBlockNumberFormatter(this.parameters[0]);

diff --git a/packages/web3-core-method/tests/src/methods/block/GetBlockTransactionCountMethodTest.js b/packages/web3-core-method/tests/src/methods/block/GetBlockTransactionCountMethodTest.js
@@ -20,7 +20,7 @@ describe('GetBlockTransactionCountMethod', () => {
  it('constructor check', () => {
  expect(method).toBeInstanceOf(AbstractCallMethod);
 
- expect(method.rpcMethod).toEqual('eth_getTransactionByBlockNumberAndIndex');
+ expect(method.rpcMethod).toEqual('eth_getBlockTransactionCountByNumber');
 
  expect(method.parametersAmount).toEqual(1);
 
@@ -40,7 +40,7 @@ describe('GetBlockTransactionCountMethod', () => {
 
  expect(formatters.inputBlockNumberFormatter).toHaveBeenCalledWith('0x0');
 
- expect(method.rpcMethod).toEqual('eth_getTransactionByBlockHashAndIndex');
+ expect(method.rpcMethod).toEqual('eth_getBlockTransactionCountByHash');
  });
 
  it('beforeExecution should call method with block number as parameter and call inputBlockNumberFormatter', () => {
@@ -54,7 +54,7 @@ describe('GetBlockTransactionCountMethod', () => {
 
  expect(formatters.inputBlockNumberFormatter).toHaveBeenCalledWith(100);
 
- expect(method.rpcMethod).toEqual('eth_getTransactionByBlockNumberAndIndex');
+ expect(method.rpcMethod).toEqual('eth_getBlockTransactionCountByNumber');
  });
 
  it('afterExecution should map the hex string to a number', () => {