Skip to content

Commit

Permalink
address feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
luu-alex committed Sep 18, 2024
1 parent e63c7c3 commit 8c0bbc1
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 5 deletions.
1 change: 0 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2708,7 +2708,6 @@ If there are any bugs, improvements, optimizations or any new feature proposal f
#### web3-core

- Adds a new property (`customTransactionSchema`) to `Web3ConfigOptions` (#7227)
- Adds a new property (`config`) to `Web3RequestManager` (#7227)

#### web3-eth

Expand Down
1 change: 0 additions & 1 deletion packages/web3-core/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,5 @@ Documentation:
### Added

- Adds a new property (`customTransactionSchema`) to `Web3ConfigOptions`(#7227)
- Adds a new property (`config`) to `Web3RequestManager` (#7227)

## [Unreleased]
2 changes: 1 addition & 1 deletion packages/web3-eth-personal/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ Documentation:

- Dependencies updated

## [4.0.9]
## [4.1.0]

### Changed

Expand Down
2 changes: 1 addition & 1 deletion packages/web3-eth-personal/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "web3-eth-personal",
"version": "4.0.9",
"version": "4.1.0",
"description": "Web3 module to interact with the Ethereum blockchain accounts stored in the node.",
"main": "./lib/commonjs/index.js",
"module": "./lib/esm/index.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/web3/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
"web3-eth-contract": "^4.7.0",
"web3-eth-ens": "^4.4.0",
"web3-eth-iban": "^4.0.7",
"web3-eth-personal": "^4.0.9",
"web3-eth-personal": "^4.1.0",
"web3-net": "^4.1.0",
"web3-providers-http": "^4.2.0",
"web3-providers-ws": "^4.0.8",
Expand Down

1 comment on commit 8c0bbc1

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 8c0bbc1 Previous: a21078b Ratio
processingTx 22385 ops/sec (±7.24%) 22494 ops/sec (±8.39%) 1.00
processingContractDeploy 38514 ops/sec (±7.96%) 38470 ops/sec (±7.11%) 1.00
processingContractMethodSend 15946 ops/sec (±7.70%) 16121 ops/sec (±6.53%) 1.01
processingContractMethodCall 27112 ops/sec (±7.56%) 28342 ops/sec (±6.29%) 1.05
abiEncode 44094 ops/sec (±6.80%) 43839 ops/sec (±6.81%) 0.99
abiDecode 31351 ops/sec (±7.28%) 30836 ops/sec (±5.71%) 0.98
sign 1563 ops/sec (±0.72%) 1545 ops/sec (±3.43%) 0.99
verify 365 ops/sec (±2.51%) 370 ops/sec (±0.49%) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.