Skip to content

Commit

Permalink
Fix some comments (#6878)
Browse files Browse the repository at this point in the history
Signed-off-by: pengqiseven <i@sohu.com>
Co-authored-by: pengqiseven <i@sohu.com>
  • Loading branch information
pengqiseven and pengqiseven authored Mar 11, 2024
1 parent e383ae3 commit d254316
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ sidebar_label: web3.eth.Contract

### Receipt Status

The `receipt.status` will now be be an `unsigned integer` instead of `boolean` value to comply with the specification.
The `receipt.status` will now be an `unsigned integer` instead of `boolean` value to comply with the specification.

```ts
// in 1.x
Expand Down
2 changes: 1 addition & 1 deletion packages/web3-eth/test/e2e/e2e_utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ along with web3.js. If not, see <http://www.gnu.org/licenses/>.
*/

/**
* @NOTE This Util method is kept seperate from shared system_test_utils.ts file because
* @NOTE This Util method is kept separate from shared system_test_utils.ts file because
* of it's import of .secrets.json. For this method to exist in shared system_test_utils.ts
* file, the import path would be ../.secrets.json which doesn't resolve when the file is
* copied over to each package's test directory. Because web3 package is the only package
Expand Down
2 changes: 1 addition & 1 deletion packages/web3-types/src/eth_types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -548,7 +548,7 @@ export interface FeeData {
readonly gasPrice?: Numbers;

/**
* The baseFeePerGas returned from the the last available block.
* The baseFeePerGas returned from the last available block.
*
* If EIP-1559 is not supported, this will be `undefined`
*
Expand Down
2 changes: 1 addition & 1 deletion packages/web3/test/e2e/e2e_utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ along with web3.js. If not, see <http://www.gnu.org/licenses/>.
*/

/**
* @NOTE This Util method is kept seperate from shared system_test_utils.ts file because
* @NOTE This Util method is kept separate from shared system_test_utils.ts file because
* of it's import of .secrets.json. For this method to exist in shared system_test_utils.ts
* file, the import path would be ../.secrets.json which doesn't resolve when the file is
* copied over to each package's test directory. Because web3 package is the only package
Expand Down

1 comment on commit d254316

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: d254316 Previous: 6c075db Ratio
processingTx 8942 ops/sec (±3.63%) 9301 ops/sec (±4.81%) 1.04
processingContractDeploy 36004 ops/sec (±7.12%) 39129 ops/sec (±7.62%) 1.09
processingContractMethodSend 18230 ops/sec (±8.36%) 19443 ops/sec (±5.19%) 1.07
processingContractMethodCall 37296 ops/sec (±5.30%) 38971 ops/sec (±6.34%) 1.04
abiEncode 42326 ops/sec (±7.89%) 44252 ops/sec (±6.92%) 1.05
abiDecode 30120 ops/sec (±8.87%) 30419 ops/sec (±8.89%) 1.01
sign 1585 ops/sec (±2.78%) 1656 ops/sec (±4.08%) 1.04
verify 370 ops/sec (±0.50%) 373 ops/sec (±0.78%) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.