Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract examples aren't waiting for contracts to be confirmed before calling them #133

Closed
drcode opened this issue Mar 20, 2015 · 2 comments
Labels
Enhancement Includes improvements or optimizations
Milestone

Comments

@drcode
Copy link

drcode commented Mar 20, 2015

Hi, near as I can tell, the contract.html example code won't work if the user presses the second button before waiting for the contract to be confirmed first. (at least when using the go-ethereum client)

Shouldn't there be some code that waits for the contract to be confirmed before enabling the ability to call?

This would be especially valuable since there is little documentation as to how one actually can tell when a transaction has confirmed... I realize I can use "web3.eth.filter('latest').watch()", but that function doesn't seem to give me any info on a specific transaction's confirmation status...

Also: I believe your examples are still missing the "From" parameter that is required by the latest go-ethereum client.

@debris debris added this to the 0.3.0 milestone Mar 31, 2015
@frozeman
Copy link
Contributor

To see if a tx was mined you could check the next blocks tx and see if the from is matching your sending address.

Could be done in a simple script.

@frozeman frozeman added the Enhancement Includes improvements or optimizations label Apr 21, 2015
@debris debris modified the milestones: 0.4.0, 0.3.0 Apr 23, 2015
debris added a commit that referenced this issue May 13, 2015
debris added a commit that referenced this issue May 13, 2015
@debris
Copy link
Contributor

debris commented May 13, 2015

on latest develop contract.html and event_inc.html are waiting for mining the block.

@debris debris closed this as completed May 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Includes improvements or optimizations
Projects
None yet
Development

No branches or pull requests

3 participants