-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid chainId used to sign transactions #2378
Labels
Bug
Addressing a bug
Comments
gabmontes
added a commit
to autonomoussoftware/metronome-wallet-core
that referenced
this issue
Feb 15, 2019
Related to web3/web3.js#2378
Will check and fix this in the current working branch (#2367) |
13 tasks
This was referenced Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected behavior
When signing transactions in Ethereum Classic (might be applicable to other chains as well), the signing logic in the accounts package shall use the proper
chainId
(i.e. 61/62) if it is not specified in the transaction object by callingeth_chainId
RPC.Actual behavior
In the above mentioned case, the chainId value is actually retrieved using the
net_version
RPC call, which does return an incorrect value (prior EIP-155).Steps to reproduce the behavior
chainId
value 61/62.Error Logs
N/A
Versions
Web3.js@1.0.0-beta.37
Related to #1644.
A quick fix for beta.37 and previous versions is to apply this patch:
The text was updated successfully, but these errors were encountered: