-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web3EthereumProvider does not await Promise from connection #2857
Labels
Bug
Addressing a bug
Comments
Thanks for opening this issue! Because of the unclear state of this EIP did I stop to update or fix the EthereumProvider handling of Web3. Feel free to fix this and I will try to push this EIP to a final state. |
This got fixed with PR: #2854 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm testing an implementation of EthereumProvider using web3 1.0.0-beta.55, and it appears there is an issue with the Web3EthereumProvider adapter. All my requests error with: "".
It looks like this line is missing an
await
, sincesend()
returns a Promise in EthereumProvider.https://github.com/ethereum/web3.js/blob/e48511990199330cf5b100ed52dd7953df934ab3/packages/web3-providers/src/providers/Web3EthereumProvider.js#L132
I'd be happy to open a PR if this is indeed a bug.
The text was updated successfully, but these errors were encountered: