Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web3EthereumProvider does not await Promise from connection #2857

Closed
pixelmatrix opened this issue May 29, 2019 · 3 comments
Closed

Web3EthereumProvider does not await Promise from connection #2857

pixelmatrix opened this issue May 29, 2019 · 3 comments
Labels
Bug Addressing a bug

Comments

@pixelmatrix
Copy link

I'm testing an implementation of EthereumProvider using web3 1.0.0-beta.55, and it appears there is an issue with the Web3EthereumProvider adapter. All my requests error with: "".

It looks like this line is missing an await, since send() returns a Promise in EthereumProvider.
https://github.com/ethereum/web3.js/blob/e48511990199330cf5b100ed52dd7953df934ab3/packages/web3-providers/src/providers/Web3EthereumProvider.js#L132

I'd be happy to open a PR if this is indeed a bug.

@nivida
Copy link
Contributor

nivida commented May 30, 2019

Thanks for opening this issue! Because of the unclear state of this EIP did I stop to update or fix the EthereumProvider handling of Web3. Feel free to fix this and I will try to push this EIP to a final state.

@nivida nivida added the Bug Addressing a bug label May 30, 2019
@nivida
Copy link
Contributor

nivida commented May 30, 2019

This got fixed with PR: #2854

@nivida nivida closed this as completed May 30, 2019
@pixelmatrix
Copy link
Author

pixelmatrix commented May 31, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Addressing a bug
Projects
None yet
Development

No branches or pull requests

2 participants