Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unit Tests for web3-eth PromiEvents #4810

Closed
spacesailor24 opened this issue Mar 2, 2022 · 0 comments
Closed

Add Unit Tests for web3-eth PromiEvents #4810

spacesailor24 opened this issue Mar 2, 2022 · 0 comments
Assignees
Labels
4.x 4.0 related

Comments

@spacesailor24
Copy link
Contributor

sendTransaction and sendSignedTransaction don't have unit tests that verify PromiEvent functionality

@spacesailor24 spacesailor24 added the 4.x 4.0 related label Mar 2, 2022
@spacesailor24 spacesailor24 self-assigned this Mar 17, 2022
spacesailor24 added a commit that referenced this issue Mar 31, 2022
… tests #4810 (#4875)

* WIP Web3Eth.sendTransaction tests

* Update use of ReceiptInfo and TransactionReceipt to ReceiptInfoFormatted

* Add optional data field to BaseTransaction

* Init sendTransaction test and fixture

* Remove old sendTransactionValidData

* Remove no longer needed imports

* Remove errornous sendTransaction test

* Init getGasPricing tests for sendTransaction

* Init wait_for_transaction_receipt.ts

* Init watch_transaction_for_confirmations.ts

* Import waitForTransactionReceipt and watchTransactionForConfirmations from utils/

* Init waitForTransactionReceipt and watchTransactionForConfirmations tests

* Fix promiEvent bug with sendSignedTransaction

* Use HexString for expectedTransactionHash instead of string

* Remove jest.useRealTimers

* Init sendSignedTransaction tests

* Update use of ReceiptInfo to ReceiptInfoFormatted for sendSignedTransaction

* Remove unused import ReceiptInfo

* Update SendSignedTransactionEvents to include only unique properties

* Add transactionHash to TransactionMissingReceiptOrBlockHashError

* Update packages/web3-eth/src/errors.ts

* Add effectiveGasPrice to sendSignedTransaction and sendTransaction fixtures

* Add expectedTransactionHash to watchTransactionForConfirmationsSpy tests

* Update names of files to match existing casings

* Merge with #4859

* Update import for ReceiptInfo

* Add effectiveGasPrice to transactionSchema

* Update SendTransactionEvents and SendSignedTransactionEvents types

* Add transaction receipt formatting

Co-authored-by: Alex <alex.luu@mail.utoronto.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x 4.0 related
Projects
None yet
Development

No branches or pull requests

1 participant