Handle overload functions #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frozeman
approved these changes
Nov 20, 2017
|
This is definitely a useful fix, thought because of this reason there is also the function signature as well as the function name. As even with this fix, we have the problem there can be overloaded functions with the same parameter amount, just different types. |
frozeman
reviewed
Nov 20, 2017
| var cascadeFunc = _this._createTxObject.bind({ | ||
| method: method, | ||
| parent: _this, | ||
| next: _this.methods[method.name] |
There was a problem hiding this comment.
Could we please rename this to: next -> nextMethod
btw we have the same issue for events :0
nachomazzara
pushed a commit
to nachomazzara/web3.js
that referenced
this pull request
Jun 4, 2020
* Handle overload functions * next -> nextMethod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries all the functions until it finds a one that matches the number of parameters.
Solves #924