treat RLP 'r' and 's' fields as quantity, not string

[jellegerbrandy]

This fixes #1170 by using the patch provided by @ldn0x7dc in that issue

[coveralls]

Coverage decreased (-0.005%) to 85.703% when pulling 70c0198 on Paratii-Video:1170-RLP-encoding into 6816ce5 on ethereum:1.0.

[carver]

This change in output seems like the right thing to do, but it doesn't completely fix #1170. r and s fields should have single leading 0s trimmed as well (when returned individually in https://github.com/ethereum/web3.js/pull/1258/files#diff-7bb2a20126193b9ecfe4723f83429c49R168 ).

[jellegerbrandy]

You are right of course; should be better now

[coveralls]

Coverage increased (+0.03%) to 85.741% when pulling 3f5ea28 on Paratii-Video:1170-RLP-encoding into 6816ce5 on ethereum:1.0.

[malissa]

Would love to get this merged in!

[jellegerbrandy]

Applying the patch in our code, and running it against parity, returns the following error (from Parity):

Invalid params: Invalid bytes format. Expected a 0x-prefixed hex string with even length.

Apparently, the issue is more complex than I had hoped. This issue seems related as well: ethereumjs/ethereumjs-tx#51

In our code, we have gone back to the "strip two leading zeros" code, and that seems to work fine against parity.

[malissa]

@jellegerbrandy I also received an error (using geth) when stripping zeros resulted in an odd numbered string. I will try removing two leading zeros - should at least improve the number of times I receive this error which is A LOT.

[jellegerbrandy]

I reverted the commit stripping all leading zeros, which clearly was mistaken. Apparently, geth and parity expect strings with an even number of characters that do not start with 0x00... the documentation does not help me much here, unfortunately..

[coveralls]

Coverage decreased (-0.005%) to 85.703% when pulling 992a87a on Paratii-Video:1170-RLP-encoding into 6816ce5 on ethereum:1.0.

[carver]

RLP encoding is one byte at the smallest unit. Represented as a hex string, that's two hex characters at a time. So for the rlp encoding here, it should only trim null bytes (double 0 hex characters): https://github.com/ethereum/web3.js/pull/1258/files#diff-7bb2a20126193b9ecfe4723f83429c49R162

But for the r and s values, which are not RLP-encoded when returned individually, they should trim down all leading hex 0 characters. https://github.com/ethereum/web3.js/pull/1258/files#diff-7bb2a20126193b9ecfe4723f83429c49R168

[frozeman]

Thanks for the fix! And sorry for the delay, i was not available over christmas.

[malissa]

Woot! Thanks for this!

[frozeman]

It would be good to add a few test cases, does somebody have a tx and key which results in the 0x00.. r, s values?

[malissa]

Of course now I am unable to get an error. I will comment here if I come across one.

[carver]

I just posted short r & s values in #1170

[frozeman]

@malissa you could use a previous commit :)