Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test transaction with short r and s fields #1290

Merged
merged 5 commits into from
Jan 22, 2018
Merged

Test transaction with short r and s fields #1290

merged 5 commits into from
Jan 22, 2018

Conversation

carver
Copy link
Contributor

@carver carver commented Jan 11, 2018

See #1289

This is a demonstration of how a transaction cannot be recovered if the r and/or s fields are short (but valid).

@carver carver mentioned this pull request Jan 15, 2018
Merged
@carver carver mentioned this pull request Jan 15, 2018
Merged
@coveralls
Copy link

coveralls commented Jan 18, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 85.741% when pulling 1ad4f2b on carver:short-r-and-s into 4429d15 on ethereum:1.0.

@frozeman frozeman merged commit 2386448 into web3:1.0 Jan 22, 2018
@carver carver deleted the short-r-and-s branch January 22, 2018 19:13
nachomazzara pushed a commit to nachomazzara/web3.js that referenced this pull request Jun 4, 2020
@carver @nachomazzara
test transaction with short r and s fields (web3#1290)
93c2395
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frozeman frozeman frozeman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carver @coveralls @frozeman