Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Conversation

@nujabes403
Copy link
Contributor

Some code's indentation is not aligned.

I applied code indentation according to some convention like below:

  1. Add a space between comma and element item.
    (0,5) -> (0, 5)

  2. Add a space between curly bracket and parenthesis.
    if (this.host.substring(0,5) === "https"){
    ->
    if (this.host.substring(0, 5) === "https") {

  3. Add a space between reserved keyword and curly bracket.
    }else{
    ->
    } else {

Sometimes it is hard to follow the code convention rules, since there are so many different code convention. however, there is a 'anti-pattern' which harms readability to make hard finding bugs. I just fixed some 'anti-pattern' in this file. :)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.169% when pulling aad8a7b on nujabes403:code-align into 0de98a5 on ethereum:1.0.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.169% when pulling aad8a7b on nujabes403:code-align into 0de98a5 on ethereum:1.0.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.169% when pulling aad8a7b on nujabes403:code-align into 0de98a5 on ethereum:1.0.

@nivida
Copy link
Contributor

nivida commented Oct 25, 2018

@nujabes403 I'll close this PR because I already fixed the code style here #2000

@nivida nivida closed this Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants