Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web3 eth iban types #2090

Merged
merged 11 commits into from
Dec 6, 2018
Merged

Web3 eth iban types #2090

merged 11 commits into from
Dec 6, 2018

Conversation

joshstevens19
Copy link
Contributor

@joshstevens19 joshstevens19 commented Dec 2, 2018 •
edited
Loading

Here are the web3-eth-iban types + tests.

All the tests are done and because it was all for 1 class it has stayed in 1 file as it made me sense.

Also looking at this package i think we should delete leftPad method in Iban.js and use the Utils leftPad method 😄

👍

@nivida nivida added the Enhancement Includes improvements or optimizations label Dec 3, 2018
@joshstevens19
Copy link
Contributor Author

Think this now can be merged in :)

@nivida
Copy link
Contributor

nivida commented Dec 4, 2018

I'll test it tomorrow and when all tests run as expected I'll merge it.
Thanks 👍

@nivida nivida merged commit 672323b into web3:ethereumProvider Dec 6, 2018
@joshstevens19 joshstevens19 mentioned this pull request Dec 9, 2018
Closed
4 tasks
@joshstevens19 joshstevens19 mentioned this pull request Sep 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nivida nivida nivida approved these changes

Assignees
No one assigned
Labels
Enhancement Includes improvements or optimizations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshstevens19 @nivida